if of_find_device_by_node() succeed, qcom_iommu_of_xlate() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.

Fixes: e86d1aa8b60f ("iommu/arm-smmu: Move Arm SMMU drivers into their own 
subdirectory")
Signed-off-by: Yu Kuai <yuku...@huawei.com>
---
 drivers/iommu/arm/arm-smmu/qcom_iommu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c 
b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
index 9535a6af7553..7a9594d221e0 100644
--- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
+++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
@@ -584,8 +584,10 @@ static int qcom_iommu_of_xlate(struct device *dev, struct 
of_phandle_args *args)
         * index into qcom_iommu->ctxs:
         */
        if (WARN_ON(asid < 1) ||
-           WARN_ON(asid > qcom_iommu->num_ctxs))
+           WARN_ON(asid > qcom_iommu->num_ctxs)) {
+               put_device(&iommu_pdev->dev);
                return -EINVAL;
+       }
 
        if (!dev_iommu_priv_get(dev)) {
                dev_iommu_priv_set(dev, qcom_iommu);
@@ -595,6 +597,7 @@ static int qcom_iommu_of_xlate(struct device *dev, struct 
of_phandle_args *args)
                 * banks are ok, but multiple devices are not:
                 */
                if (WARN_ON(qcom_iommu != dev_iommu_priv_get(dev)))
+                       put_device(&iommu_pdev->dev);
                        return -EINVAL;
        }
 
-- 
2.25.4

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to