… > +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c … > @@ -595,6 +597,7 @@ static int qcom_iommu_of_xlate(struct device *dev, struct > of_phandle_args *args) > * banks are ok, but multiple devices are not: > */ > if (WARN_ON(qcom_iommu != dev_iommu_priv_get(dev))) > + put_device(&iommu_pdev->dev); > return -EINVAL; > }
* Would there be a need to use curly brackets for such an if branch? * I suggest to add a jump target so that a bit of common exception handling code can be better reused for this function implementation. Regards, Markus _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
