Use sysfs_emit instead of scnprintf, snprintf or sprintf.

Signed-off-by: Tony Battersby <to...@cybernetics.com>
---

Changes since v5:
This patch was not in v5.

 mm/dmapool.c | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index 0f89de408cbe..1829291f5d70 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -64,18 +64,11 @@ static DEFINE_MUTEX(pools_reg_lock);
 
 static ssize_t pools_show(struct device *dev, struct device_attribute *attr, 
char *buf)
 {
-       unsigned temp;
-       unsigned size;
-       char *next;
+       int size;
        struct dma_page *page;
        struct dma_pool *pool;
 
-       next = buf;
-       size = PAGE_SIZE;
-
-       temp = scnprintf(next, size, "poolinfo - 0.1\n");
-       size -= temp;
-       next += temp;
+       size = sysfs_emit(buf, "poolinfo - 0.1\n");
 
        mutex_lock(&pools_lock);
        list_for_each_entry(pool, &dev->dma_pools, pools) {
@@ -90,16 +83,14 @@ static ssize_t pools_show(struct device *dev, struct 
device_attribute *attr, cha
                spin_unlock_irq(&pool->lock);
 
                /* per-pool info, no real statistics yet */
-               temp = scnprintf(next, size, "%-16s %4u %4zu %4zu %2u\n",
-                                pool->name, blocks,
-                                pages * (pool->allocation / pool->size),
-                                pool->size, pages);
-               size -= temp;
-               next += temp;
+               size += sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n",
+                                     pool->name, blocks,
+                                     pages * (pool->allocation / pool->size),
+                                     pool->size, pages);
        }
        mutex_unlock(&pools_lock);
 
-       return PAGE_SIZE - size;
+       return size;
 }
 
 static DEVICE_ATTR_RO(pools);
-- 
2.25.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to