On Mon, Jun 6, 2016, at 01:24 PM, Gregg Reynolds wrote: > Hi list, > > I got a comment on a patch I submitted (yay!) but I searched the wiki > and can find no instructions as to how to respond.? So I just uploaded > an amended patch.? But there must be a way to respond in order to > discuss.? How?
I'm not sure if there is any detail on the wiki for this, so I'll rundown a quick summary. When in Gerrit you can hit the drop-down for past revisions to see the comments entered there. For the in-line comments on files you can then just select an individual comment and then you should get a few options at the bottom, including "Reply" For change-wide comments I believe you'd just hit "Reply" on the main change UI and add things in. So it does show that the in-line comments are a bit more helpful for a discussion. A common thing to do when fixing some point is to update a new changeset but then go back to the prior revision and reply to the individual comments with "Done" for points that have been addressed. -- Jon A. Cruz jon at joncruz.org -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20160606/f160c863/attachment.html>
