On Mon, Jun 6, 2016 at 3:46 PM, Jon A. Cruz <jon at joncruz.org> wrote:
> On Mon, Jun 6, 2016, at 01:24 PM, Gregg Reynolds wrote: > > Hi list, > > I got a comment on a patch I submitted (yay!) but I searched the wiki and > can find no instructions as to how to respond. So I just uploaded an > amended patch. But there must be a way to respond in order to discuss. > How? > > > I'm not sure if there is any detail on the wiki for this, so I'll rundown > a quick summary. > > When in Gerrit you can hit the drop-down for past revisions to see the > comments entered there. For the in-line comments on files you can then just > select an individual comment and then you should get a few options at the > bottom, including "Reply" > Thanks. I found that clicking on the file link for a particular comment would take me to the diff page where the comment was displayed as a yellow PDF notation-style overlay comment. Being reckless I clicked on the comment and lo and behold, a popup popped up allowing me to respond. Something for the wiki, if I can find the time. > > For change-wide comments I believe you'd just hit "Reply" on the main > change UI and add things in. So it does show that the in-line comments are > a bit more helpful for a discussion. > Yep. I had seen that but was too cowardly to try it - thought I might be replying to the entire internet. > > A common thing to do when fixing some point is to update a new changeset > but then go back to the prior revision and reply to the individual comments > with "Done" for points that have been addressed. > Thanks, G -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20160606/7dded02b/attachment.html>
