Hi Philippe, Thanks for the proposals. We are doing something similar to option 1. Problem is sometimes original author is bottleneck as he is the only person authorized to submit a change.
If we do option 2, would the changes be under the same patch and different authors will be allowed? As for option 3, seems so complex. Do you mean original author changing author to the other person? But then gerrit ssh would not allow updates as the credentials of the two users are different. I am not sure I fully grasp what you said. As you said, it is not good to twist it now as new users of gerrit. I thought there is some option to allow this mode of work. I hope option 2 you proposed can work. Khaled On Thu, Jan 12, 2017 at 1:51 PM, Philippe Coval < philippe.coval at osg.samsung.com> wrote: > > > On 12/01/17 10:21, Khaled Elsayed wrote: > > ?Adding to what Morten mentioned, I have the following issue: > > If two developers are working on the same patch, how to allow the other > developer (i.e. the one who did not originally submit the patch) to make an > update from his local machine? In our case, I had to submit the patch > manually to the other developer who would then push the update to gerrit. > This causes unnecessary details. > > I am sure there must be some way but I cannot find it as a new user of > gerrit. > > > > Hi Khaled, > > I know what you mean and I know a couple of options to sort it out, > but I am not sure if any are officially supported by project: > > 1/ > Work together outside project ? > One option is to fork http://github.com/iotivity/iotivity > and once ready submit change back to gerrit > this what only matters to project. > > 2/ > Change last digit of the ChangeId: and push again, and track yourselves > but it can be confusing. > you can add Topic labels in gerrit to connect them ie: > https://gerrit.iotivity.org/gerrit/#/q/project:iotivity+ > branch:master+topic:IOT-1320 > > 3/ > To achieve multiple author incremental review, > you need to "steal" authorship of patch, this mean changing the Author: to > you, > this should not be done, but I've did this a couple of time to unblock > situations. > > So if you really need to, make sure to contact original author for > permission, > and try to get the author setting back his name as Author: > and make sure your name is also in Signed-off: > A polite way is to add Credit-to: .. as gerrit meta data field too. > > > Hope this help. > > But gerrit can be messy, so better get used to it before twisting it ;) > > On that topic to help other maintainers, > I started to add topics on unlabeled changes. > > Like if you are submitting changes related to build issues I will track > them in: > https://gerrit.iotivity.org/gerrit/#/q/status:open+ > project:iotivity+topic:build > > Hope this help to find the right reviewer. > > > My 2c > > -- mailto:philippe.coval at osg.samsung.com <philippe.coval at > osg.samsung.com> gpg:0x467094BChttps://blogs.s-osg.org/author/pcoval/ > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20170112/5bd7b42c/attachment.html>
