Changing author was required, I got this error otherwise: remote: ERROR: In commit b1fb8a7585b9dd6d965bc6ce16f45fdb67056afa remote: ERROR: author email address kkane at microsoft.com remote: ERROR: does not match your user account. remote: ERROR: remote: ERROR: The following addresses are currently registered: remote: ERROR: mike.f.finch at lowes.com remote: ERROR: remote: ERROR: To register an email address, please visit: remote: ERROR: https://gerrit.iotivity.org/gerrit/#/settings/contact
but after changing author it updated fine. We should have a discussion on if you come back and change it again do you add annother signed-off on the bottom, that way it's obvious who the last person to touch was, or as long as everyone hwo committed signed off at least once are we OK? Mike ________________________________ From: Kevin Kane [kk...@microsoft.com] Sent: Monday, January 16, 2017 3:23 PM To: Finch, Mike - Michael; khaledieee at gmail.com Cc: iotivity-dev at lists.iotivity.org Subject: RE: [dev] visiting "how to use Gerrit" topic Hey Mike, I?ve repackaged your change as one of my own purely for the purposes of testing. Please try and push an updated patch set to this commit: https://gerrit.iotivity.org/gerrit/16441 From: Finch, Mike - Michael [mailto:mike.f.fi...@lowes.com] Sent: Monday, January 16, 2017 11:57 AM To: Kevin Kane <kkane at microsoft.com>; khaledieee at gmail.com Cc: iotivity-dev at lists.iotivity.org Subject: RE: [dev] visiting "how to use Gerrit" topic I'm happy to let someone try a test in my change https://gerrit.iotivity.org/gerrit/#/c/16333/2,<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgerrit.iotivity.org%2Fgerrit%2F%23%2Fc%2F16333%2F2%2C&data=02%7C01%7Ckkane%40microsoft.com%7C3e97e6f2974e42e02d8008d43e49bcdf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636201933809044379&sdata=3UKMe0VRfYdV%2FoHOVgbRCbStXhmiHfF%2FyFCXfIplBnc%3D&reserved=0> or let me know one you want me to try on of yours. There is not one of someone else's that I'm comfortable editing to test now. My memory was that if you did not change the author on the commit gerrit rejected it. Mike ________________________________ From: Kevin Kane [kk...@microsoft.com] Sent: Monday, January 16, 2017 1:36 PM To: Finch, Mike - Michael; khaledieee at gmail.com<mailto:khaledieee at gmail.com> Cc: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: RE: [dev] visiting "how to use Gerrit" topic The key here is to make sure the ?Change-Id? line in the commit comment is the same as the change you?re updating; this is how Gerrit will identify the new commit you?re pushing as an update of an existing change. When you commit, use the ?-s? parameter to add your own ?Signed-off-by? header if yours isn?t already present (but don?t delete anyone else?s!). I don?t think you have to update the author; I haven?t done this in the past, but I?ve only made minor changes and so figured the original author should still be listed as author. You might do this if you make substantial enough changes that the change is more your work than the previous author?s. If you run into permission problems, though, let us know and we should be able to get that fixed. Please copy the exact output from ?git push? so we can see the error message Gerrit returns. From: iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org> [mailto:iotivity-dev-boun...@lists.iotivity.org] On Behalf Of Finch, Mike - Michael Sent: Monday, January 16, 2017 5:58 AM To: khaledieee at gmail.com<mailto:khaledieee at gmail.com> Cc: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: Re: [dev] visiting "how to use Gerrit" topic Sorry new patch, ie. pull patch in gerrit make changes git commit --amend --author="Author Name <email at address.com<mailto:email at address.com>>" -s new commit message, keep commit ID & all prior signatures push back to refs/for... I don't know if it will work, have to try. Both Alljoyn and Iotivity are linux foundation projects, but I don't know how much custom configuration was done. Mike ________________________________ From: khaled at ieee.org<mailto:khaled at ieee.org> [khaled at ieee.org] on behalf of Khaled Elsayed [khaledi...@gmail.com] Sent: Monday, January 16, 2017 8:40 AM To: Finch, Mike - Michael Cc: Mats Wichmann; Thiago Macieira; ??? (Uze Choi); iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: Re: [dev] visiting "how to use Gerrit" topic Hi Mike, This is exactly what I was asking for. Could you explain what do you mean by submitting a new path? Is what you illustrate below doable on current gerrit for iotivity? I tried submitting using different author name for a specific patch but gerrit always refuses the patch. Best regards, Khaled On Fri, Jan 13, 2017 at 4:24 AM, Finch, Mike - Michael <mike.f.finch at lowes.com<mailto:mike.f.finch at lowes.com>> wrote: In allseen alliance we would routinely change author on a change and submit a new path, each time the author changed a new sign off line was added. this particular change had 31 patch sets and the commit message looked like this: SmartSpaces Operation interface definitions v1. Change-Id: I84c7a2abbcfef908c6a005a5f097256b93da69dd Signed-off-by: Stefano Toppan <stefano.toppan at electrolux.it<mailto:stefano.toppan at electrolux.it>> Signed-off-by: Dongwon Kim <dongwon00.kim at lge.com<mailto:dongwon00.kim at lge.com>> Signed-off-by: seungchul.han <seungchul.han at lge.com<mailto:seungchul.han at lge.com>> Signed-off-by: Mike Finch <mike.f.finch at lowes.com<mailto:mike.f.finch at lowes.com>> Signed-off-by: youngkyun.jin <youngkyun.jin at lge.com<mailto:youngkyun.jin at lge.com>> Signed-off-by: Stefano Toppan <stefano.toppan at electrolux.it<mailto:stefano.toppan at electrolux.it>> Signed-off-by: seungchul.han <seungchul.han at lge.com<mailto:seungchul.han at lge.com>> Signed-off-by: Stefano Toppan <stefano.toppan at electrolux.it<mailto:stefano.toppan at electrolux.it>> ________________________________________ From: iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org> [iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org>] on behalf of Mats Wichmann [mats at wichmann.us<mailto:m...@wichmann.us>] Sent: Thursday, January 12, 2017 5:37 PM To: Thiago Macieira; ??? (Uze Choi) Cc: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: Re: [dev] visiting "how to use Gerrit" topic On 01/12/2017 01:30 PM, Thiago Macieira wrote: > On quinta-feira, 12 de janeiro de 2017 17:35:42 PST ??? (Uze Choi) wrote: >>> 6. Is there a policy on whether commits require a matching Jira ticket? >>> Mandatory? Suggested? Completely optional? >> >> Current policy is that it's optional, except for during RC time. At that >> time, every change to be accepted into the next RC needs to have a matching >> JIRA ticket of sufficient priority. RM and QA set the rules. >> >> [Uz] -> Better to put the jira code into commit title as rule in case there >> is associated jira. > > Agreed, but please emphasise the change, not the bug report. > > Correct: > IOT-1234: Fix implementation of doodad that failed to frobniz correctly > > Bad: > Fix bug IOT-1234 > > Thanks to all who have commented on this topic. Not sure quite how to update the wiki page, I may make a copy and ask for reviews on that before replacing the content of the current one. I didn't get there was any great way for multiple developers to cooperate on one change, which was one direction the discussion went. Did I miss something? _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> https://lists.iotivity.org/mailman/listinfo/iotivity-dev<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.iotivity.org%2Fmailman%2Flistinfo%2Fiotivity-dev&data=02%7C01%7Ckkane%40microsoft.com%7Cbdf9a974d1534f8efed108d43e17a02d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636201718582614919&sdata=Lc226WHFeCAyhR9J5LuhR5a9b7P0iZ9SNsWUDwIJI2g%3D&reserved=0> NOTICE: All information in and attached to the e-mails below may be proprietary, confidential, privileged and otherwise protected from improper or erroneous disclosure. If you are not the sender's intended recipient, you are not authorized to intercept, read, print, retain, copy, forward, or disseminate this message. If you have erroneously received this communication, please notify the sender immediately by phone (704-758-1000) or by e-mail and destroy all copies of this message electronic, paper, or otherwise. By transmitting documents via this email: Users, Customers, Suppliers and Vendors collectively acknowledge and agree the transmittal of information via email is voluntary, is offered as a convenience, and is not a secured method of communication; Not to transmit any payment information E.G. credit card, debit card, checking account, wire transfer information, passwords, or sensitive and personal information E.G. Driver's license, DOB, social security, or any other information the user wishes to remain confidential; To transmit only non-confidential information such as plans, pictures and drawings and to assume all risk and liability for and indemnify Lowe's from any claims, losses or damages that may arise from the transmittal of documents or including non-confidential information in the body of an email transmittal. Thank you. _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> https://lists.iotivity.org/mailman/listinfo/iotivity-dev<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.iotivity.org%2Fmailman%2Flistinfo%2Fiotivity-dev&data=02%7C01%7Ckkane%40microsoft.com%7Cbdf9a974d1534f8efed108d43e17a02d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636201718582614919&sdata=Lc226WHFeCAyhR9J5LuhR5a9b7P0iZ9SNsWUDwIJI2g%3D&reserved=0> NOTICE: All information in and attached to the e-mails below may be proprietary, confidential, privileged and otherwise protected from improper or erroneous disclosure. If you are not the sender's intended recipient, you are not authorized to intercept, read, print, retain, copy, forward, or disseminate this message. If you have erroneously received this communication, please notify the sender immediately by phone (704-758-1000) or by e-mail and destroy all copies of this message electronic, paper, or otherwise. By transmitting documents via this email: Users, Customers, Suppliers and Vendors collectively acknowledge and agree the transmittal of information via email is voluntary, is offered as a convenience, and is not a secured method of communication; Not to transmit any payment information E.G. credit card, debit card, checking account, wire transfer information, passwords, or sensitive and personal information E.G. Driver's license, DOB, social security, or any other information the user wishes to remain confidential; To transmit only non-confidential information such as plans, pictures and drawings and to assume all risk and liability for and indemnify Lowe's from any claims, losses or damages that may arise from the transmittal of documents or including non-confidential information in the body of an email transmittal. Thank you. NOTICE: All information in and attached to the e-mails below may be proprietary, confidential, privileged and otherwise protected from improper or erroneous disclosure. If you are not the sender's intended recipient, you are not authorized to intercept, read, print, retain, copy, forward, or disseminate this message. If you have erroneously received this communication, please notify the sender immediately by phone (704-758-1000) or by e-mail and destroy all copies of this message electronic, paper, or otherwise. By transmitting documents via this email: Users, Customers, Suppliers and Vendors collectively acknowledge and agree the transmittal of information via email is voluntary, is offered as a convenience, and is not a secured method of communication; Not to transmit any payment information E.G. credit card, debit card, checking account, wire transfer information, passwords, or sensitive and personal information E.G. Driver's license, DOB, social security, or any other information the user wishes to remain confidential; To transmit only non-confidential information such as plans, pictures and drawings and to assume all risk and liability for and indemnify Lowe's from any claims, losses or damages that may arise from the transmittal of documents or including non-confidential information in the body of an email transmittal. Thank you. NOTICE: All information in and attached to the e-mails below may be proprietary, confidential, privileged and otherwise protected from improper or erroneous disclosure. If you are not the sender's intended recipient, you are not authorized to intercept, read, print, retain, copy, forward, or disseminate this message. If you have erroneously received this communication, please notify the sender immediately by phone (704-758-1000) or by e-mail and destroy all copies of this message electronic, paper, or otherwise. By transmitting documents via this email: Users, Customers, Suppliers and Vendors collectively acknowledge and agree the transmittal of information via email is voluntary, is offered as a convenience, and is not a secured method of communication; Not to transmit any payment information E.G. credit card, debit card, checking account, wire transfer information, passwords, or sensitive and personal information E.G. Driver's license, DOB, social security, or any other information the user wishes to remain confidential; To transmit only non-confidential information such as plans, pictures and drawings and to assume all risk and liability for and indemnify Lowe's from any claims, losses or damages that may arise from the transmittal of documents or including non-confidential information in the body of an email transmittal. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20170116/c7d7acb4/attachment.html>
