|
Hello,
STEP 1 means separating files in ipadapter. Actually ipadapter include udp specific logic(socket, send, receive ..). So if I implement tcp logic in same file, it will be not easy to read some codes. So I want to separate udp logic from ipadapter.
To do that, some construct and function will change their location. Especially, because ip_context_t is core feature and all know about this, ip_context_t need to move ipadapter.h file and every .c file will include this. (I think it will be as described in the picture below)
And then I'm going to implement TCP adapter as I said in STEP 2. This will include adding TCP flag in endpoint and TCP send/receive routines. After finish implement tcp adapter, then CoAP over TCP(use these header in packet. serialize/parse also) logic should be implemented(STEP 3).
I think this will be reasonable to implement from bottom(transport). And I also agree that update linux port first. If this step is agree with you, I'll contribute TCP regarding feature soon in master branch.
Thanks. - jaehyun
--------- Original Message --------- Sender : Maloor, Kishen <kishen.mal...@intel.com> Date : 2018-03-14 02:52 (GMT+9) Title : Re: Regarding iotivity-constrained TCP contribution.
Hello, Thanks.
I’m not clear about what STEP 1 entails in your proposal.
However, the initial (and most critical) step is to
cleanly enable cross-platform support for TCP
within the framework. This work would subsume STEP 3.
Work within IP adapters themselves (STEP 1/2) should be the
last step that follows from the above work.
Which port(s) will you be updating? (I assume Linux is
starting point)
You may implement the different bits in any order of your
choosing, but I’d like to see patches in the order
prescribed above.
Also, you may submit your patches directly to master for review.
Thanks,
-Kishen. -
Kishen Maloor
Intel Open Source Technology Center From: 조제현 <jaehyun3....@samsung.com> on behalf of 조제현 <jaehyun3....@samsung.com>
Reply-To: "jaehyun3....@samsung.com" <jaehyun3....@samsung.com> Date: Monday, March 12, 2018 at 11:45 PM To: Kishen Maloor <kishen.mal...@intel.com> Cc: "iotivity-dev@lists.iotivity.org" <iotivity-dev@lists.iotivity.org> Subject: Regarding iotivity-constrained TCP contribution. Hello, I have a plan to contribute tcp feature in iotivity-constrained repository. below is contribute plan. ------------------------------------------------------------------------------------------------------ STEP 1. separate ipadapter with UDP & make space for TCP adapter. (like below) ipadapter STEP 2. implement TCP adapter. STEP 3. implement CoAP over TCP. ------------------------------------------------------------------------------------------------------
The question is that do I need to make separate branch for this? or just push to master and review for it. Thanks. jaehyun
|
_______________________________________________ iotivity-dev mailing list iotivity-dev@lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
