On a more hard technical note, at least on IBM BMCs, all the expected SOL fixes are working splendidly:
-No longer segfaults if BMC doesn't answer (tested by doing ifconfig eth0 down <enter> <enter> to force an SOL attempt when the BMC is very transiently unavailable). -Retries successfully in the event of a transiently unresponsive BMC (same test as above, ipmitool successfully retried with a reasonable packet the BMC understood as a retry and things were happy). -Get Device ID response/New SOL data no longer confused horribly (tested by taking SOL_KEEPALIVE_TIMEOUT to 0 in ipmi_sol.h, recompiling, running while :; echo -n .; done on serial console, and took wireshark trace to validate that, indeed, the BMC managed to cram SOL data packets between ipmitool sending get device id and the BMC's response. Not only did it not show up on the SOL output (like it does in ipmitool 1.8.8), but BMC is not forced to retry unnecessarily (as was the case in August CVS after the preliminary hiding of the GetDeviceID response). So the recent commit to properly fix it does the job great, usesolforkeepalive is there, but I know it breaks on IBM BMCs, so I'm not touching it ;) Just to remind myself of the bad old days, compiled 1.8.8 and indeed all these tests failed quite horribly. All I test thoroughly is SOL (use alternative IPMI stack for most things), but the basic in band and out of band (both lan and lanplus) seems to check out (sensor, sel list/elist, power status). So aside from likely minor spec file tweaks, it seems technically very solid. On Wed, 2007-01-24 at 22:17 -0500, Jarrod B Johnson wrote: > The spec file doesn't seem to work right, rpmbuild -tb on it after > changing to a tar.gz fails with: > + /usr/lib/rpm/brp-symlink > Processing files: ipmitool-1.8.8.90-1 > error: File not found by > glob: /var/tmp/ipmitool-root/usr/share/ipmitool/* > > > RPM build errors: > File not found by glob: /var/tmp/ipmitool-root/usr/share/ipmitool/* > > > This was under SLES10, FYI. 1.8.8 tar.gz builds clean with a tb. > > Also, the spec file changelog omits post 1.8.8 stuff at the moment. > > On Wed, 2007-01-24 at 21:52 +0100, Arkadiusz Miskiewicz wrote: > > On środa, 24 stycznia 2007, Arkadiusz Miskiewicz wrote: > > > On sobota, 20 stycznia 2007, Petter Reinholdtsen wrote: > > > > I just got word from Duncan Laurie, who is still too busy in his > > > > private life to work in ipmitool. He agreed to accept new project > > > > members and just made me a project manager to be able to do it. > > > > > > > > Those interested in joining the project need to speak up, and I expect > > > > those interested in getting CVS access to submit good patches to the > > > > list first to show their abilities and interest. :) > > > > > > Let's do a release 8-) I already volunteered to do this. I'll come up with > > > test tarball very soon. > > > > Here is the test tarball: > > http://ep09.pld-linux.org/~arekm/ipmitool/ipmitool-1.8.8.90.tar.bz2 > > > > md5: 8b776d8c78cb7a306d669385a975b9c1 ipmitool-1.8.8.90.tar.bz2 > > sha-1: a15068ed42be1d82272ad5066a8ea56af3a3262e ipmitool-1.8.8.90.tar.bz2 > > > > Please verify that it builds correctly and ipmitool itself works for you > > (look for regressions). > > > > Comparing to cvs it has only small almost cosmetic patch which > > fixes make distcheck, adds tinfo library to list of libraries where to look > > for tgetent > > (ncurses can be split to two libraries, small tinfo library with terminal > > only functions > > and the rest), consistently prefer ncurses over curses, don't install > > contrib > > stuff (doesn't make sense). > > > > Index: Makefile.am > > =================================================================== > > RCS file: /cvsroot/ipmitool/ipmitool/Makefile.am,v > > retrieving revision 1.15 > > diff -u -u -r1.15 Makefile.am > > --- Makefile.am 28 Jun 2006 22:04:30 -0000 1.15 > > +++ Makefile.am 24 Jan 2007 20:47:00 -0000 > > @@ -28,8 +28,8 @@ > > # LIABILITY, ARISING OUT OF THE USE OF OR INABILITY TO USE THIS SOFTWARE, > > # EVEN IF SUN HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES. > > > > -DOCDIR = $(DESTDIR)/$(datadir)/doc/$(PACKAGE) > > -DOCLIST = README COPYING AUTHORS ChangeLog > > +DOCDIR = $(datadir)/doc/$(PACKAGE) > > +DOCLIST = $(top_srcdir)/README $(top_srcdir)/COPYING $(top_srcdir)/AUTHORS > > $(top_srcdir)/ChangeLog > > > > EXTRA_DIST = $(DOCLIST) \ > > debian/changelog debian/control debian/copyright \ > > @@ -48,8 +48,11 @@ > > cp control/ipmitool.spec $(distdir) > > > > install-data-local: > > - mkdir -p $(DOCDIR) > > - $(INSTALL_DATA) -m 644 $(DOCLIST) $(DOCDIR) > > + $(MKDIR_P) $(DESTDIR)$(DOCDIR) > > + $(INSTALL_DATA) $(DOCLIST) $(DESTDIR)$(DOCDIR) > > + > > +uninstall-local: > > + -rm -rf $(DESTDIR)$(DOCDIR) > > > > .PHONY: pkg > > pkg: PKG := [EMAIL PROTECTED]@[EMAIL PROTECTED]@[EMAIL PROTECTED]@ > > @@ -67,7 +70,7 @@ > > > > .PHONY: rpm > > rpm: control/ipmitool.spec dist > > - mkdir -p $(RPMDIR)/{BUILD,RPMS,SRPMS,SOURCES,SPECS,tmp} > > + $(MKDIR_P) $(RPMDIR)/{BUILD,RPMS,SRPMS,SOURCES,SPECS,tmp} > > cp control/ipmitool.spec $(RPMDIR)/SPECS > > BUILDDIR=$(RPMDIR) CONFIGDIR=$(BUILDDIR)/control \ > > @RPMBUILD@ -ba --rcfile $(SRCDIR)/control/rpmrc \ > > Index: configure.in > > =================================================================== > > RCS file: /cvsroot/ipmitool/ipmitool/configure.in,v > > retrieving revision 1.64 > > diff -u -u -r1.64 configure.in > > --- configure.in 14 Sep 2006 16:20:58 -0000 1.64 > > +++ configure.in 24 Jan 2007 20:47:00 -0000 > > @@ -317,8 +317,8 @@ > > [enable IPMI shell interface [default=yes]])], > > [], [enable_ipmishell=yes]) > > if test "x$enable_ipmishell" = "xyes"; then > > - AC_SEARCH_LIBS([tgetent], [readline ncurses curses termcap]) > > - AC_SEARCH_LIBS([initscr], [curses ncurses], [have_curses=yes]) > > + AC_SEARCH_LIBS([tgetent], [tinfo ncurses curses readline termcap]) > > + AC_SEARCH_LIBS([initscr], [ncurses curses], [have_curses=yes]) > > AC_SEARCH_LIBS([readline], [readline edit], [have_readline=yes]) > > if test "x$have_curses" = "xyes" && test "x$have_readline" = "xyes"; > > then > > AC_DEFINE(HAVE_READLINE, [1], [Define to 1 if readline > > present.]) > > Index: contrib/Makefile.am > > =================================================================== > > RCS file: /cvsroot/ipmitool/ipmitool/contrib/Makefile.am,v > > retrieving revision 1.11 > > diff -u -u -r1.11 Makefile.am > > --- contrib/Makefile.am 19 Mar 2006 23:05:48 -0000 1.11 > > +++ contrib/Makefile.am 24 Jan 2007 20:47:00 -0000 > > @@ -30,9 +30,8 @@ > > > > MAINTAINERCLEANFILES = Makefile.in > > > > -dist_pkgdata_DATA = README oem_ibm_sel_map > > - > > -dist_pkgdata_SCRIPTS = bmclanconf ipmi.init.basic ipmi.init.redhat \ > > +EXTRA_DIST = README oem_ibm_sel_map \ > > + bmclanconf ipmi.init.basic ipmi.init.redhat \ > > ipmievd.init.redhat ipmievd.init.suse ipmievd.init.debian \ > > collect_data.sh create_rrds.sh create_webpage_compact.sh > > create_webpage.sh > > > > > > > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
