Hi, I've finished addressing the items on the fourth patch/issue list as follows:
24) As per Bernard Manjou's 6/18/08 email: ..."as expressed in my mails sent on 06/10/08 and 06/17/08, I think that all functions used to access sensors or FRUs should be modified like ipmi_sdr_get_sensor_reading_ipmb() in order to use the additional argument "I2c target address"." IMHO, this functionality change should probably be addressed after 1.8.10 rolls as it may break backward compatibility. 25) Bernard Manjou patch for timestamp issues posted on 6/30/08 has been committed to cvs. 26) Bugs in get_cmdline_ipaddr && get_cmdline_macaddr - both missing initial check for null value for 'arg'. Believe this issue was fixed by the patch for issue #14. If release testing finds there's still a hole, we can easily patch it. 27) Requested change committed to cvs. 28) IMHO this patch is not yet ready for the cvs tree. 29) Still looking this over. I have (unfounded right now :-} concerns that there may be corner cases or hw that aren't taken into account. As of right now, I'm sort of leaning toward submitting this after 1.8.10 rolls so it can live in the cvs tree for a while and get lots of testing before it's in a release. Please let me know if anyone has any strong objections to this approach. 30) Fix already in with #11 31) Fix already in with #17 Please let me know if anyone has any questions or concerns about how any of these items have been addressed. Thank you :-) Carol ---------------------------------- 24) On 10/31/07, Ben Bloom describes an issue he's seeing getting sensor readings on a non-ipmb implementation. Ben, did Holger's 11/4 workaround suggestion help? http://sourceforge.net/mailarchive/message.php?msg_name=BE55032BAC1C8441B01E9EF7CE57CC20A8EDCE%40OREXCHANGE01.radisys.com 25) SEL Timestamp issue. Issue reported by Jan Parthey on 11/23/07 and Bernard Manjou has some timestamp questions on 4/21/08. Ajay Pandey sent an illustration of the problem on Windows on 5/19/08: http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200805&viewday=19 26) Neel Chibba reports on 2/5/08 that ipmitool lan set segfaults if all args aren't supplied (ex. ipmitool lan set 1 ipaddr) My Comments: looks like this bug is still there in the current cvs tree. 27) Eric Hall writes on 2/15/08 that he'd like to have ipmi_chassis_status() (especially) changed from a static int to just an int function so he can use it in his ipmitool library. His preliminary investigation indicates that there were no namespace issues he could find. http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200802&viewday=15 My comments: We seem to have done this for a few other routines. I personally don't have any strong objections about doing it for this routine. 28) Ajay Pandey posts some ipmitool OEM enhancements for Dell on 3/12/08 http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200803&viewday=12 On 4/4/08, Brian Seklecki forwarded a post indicating that the patch is now available via ipmitool yum update: http://sourceforge.net/mailarchive/message.php?msg_name=1207526132.14963.57.camel%40new-host On 5/10/08, Subra Manuguri posted a patch that consisted of the DEL OEM command patch as well as fixes for compilation warnings. Subra's patch-delloem patch is uploaded to: http://ipmitool.wiki.sourceforge.net/space/filelist My Comments: I have some questions/concerns about the (original) patch, some of which are admittedly nitpicky, but I'll list them anyway. :-} (Well, never mind the missing header file that Subra spotted. ) Many of the new files are not named with an ipmi_ preface. There seem to be several files with Copyright issues. There doesn't appear to be any man page support for the new functionality. There seems to be a lot of code that's duplicating current functionality (sometimes with the same names); is there a way to modify/use the current ipmitool routines instead in some of these cases so as to cut down on future maintenance of two sets of similar code? 29) Tomasz Nowak reports a sdr/sensor issue 4/21/08. More info on the issue from John Philips on 5/16/08. http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200804&viewday=21 30) Bernard Manjou patch for i2c master write-read command on 5/28/08: http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200805&viewday=28 My comments: Bernard and Joshua Neal (see issue #11 in a separate email) are in agreement on this patch. ;-) Additionally, Joshua's reported that he tested it well, so let's get it in! :-) 31) Bernard Manjou patch for returning SDR Repository Free space (see link in #30). My comments: According to the spec, Bernard's fix is correct and it should go in. ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
