Hi, I've finished addressing the items on the final/fifth patch/issue list as follows:
32) Patch submitted to cvs. 33) IMHO, this functionality change should probably be addressed after 1.8.10 rolls as it may break backward compatibility. 34) Still looking this over. I have (unfounded right now :-} concerns that there may be corner cases or hw that aren't taken into account. As of right now, I'm sort of leaning toward submitting this after 1.8.10 rolls so it can live in the cvs tree for a while and get lots of testing before it's in a release. Please let me know if anyone has any strong objections to this approach. 35) As per #25, patch posted on 6/30/08 has been committed to cvs. 36) Resolution not yet designed/decided. Will probably address in a future roll. 37) Patch committed to cvs. Still need debian/changelog update. Please let me know if anyone has any questions or concerns about how any of these items have been addressed. Thank you :-) Carol -------------------------------------------------------- 32) On 5/28/08 Bernard Manjou sent in a third patch to fix an issue with the printing of discrete sensor states: http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200805&viewday=28 My comments: It looks to me like the current code in ipmi_sdr_print_discrete_state_mini() and ipmi_sdr_print_discrete_state() is wrong and that Bernard's patch will allow these print routines to address state bits 8-14. 33) On June 10th (last week), Bernard Manjou sent a patch to modify sensor, sel, and sdr routines to include sensor i2c target and lun addresses. <sorry, I can't get web pointers at the moment> My Comments: Will follow up with comments soon. 34) On 6/11/08, Lukasz Michalski sent in a pointer to a patch he'd like to have included: http://sourceforge.net/tracker/index.php?func=detail&aid=1990560&group_id=95200&atid=610552 My Comments: Will follow up with comments soon. 35) On 6/12/08, Bernard Manjou brings up the timestamp issue discussed by he and several other folks over the past year (see #25 in my 6/16/08 third patch batch email). My Comments: Bernard, I agree with your interpretation of the spec and think you could be pointing to the cause of the timestamp issues. Would you mind posting a patch for this so the folks who have been seeing timestamp issues can see if it fixes things for them? Thanks for all your patches and help. :-) 36) On 6/17/08, Bernard Manjou discussed needing to add an optional argument to ipmitool and a matching parameter to ipmi_sdr_find_sdr_byid() to match the i2c slave address as well as the sensor ID string and resolve an issue with current mishandling of sensors with the same sensor IDs. omments: Bernard, I think what you're proposing sounds like a good idea. Would you have some time to put a patch together and send it in to us? Thanks again. :-) 37.) On 6/19/08, Steffen Grunewald sent in a patch to the debian/rules file. We'll also need to update the debian/changelog to bump the version after committing the patch. My comments: Sounds good to me! ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
