Hi and Happy '09! To celebrate the New Year, I propose we start working on rolling ipmitool to v1.8.11 to include all the great fixes and patches folks have been sending in since last summer! Do you have a fix you've been using in your local ipmitool version? Send it in for review! Do you have a patch or an idea for some new functionality or support you'd like to see get into the tool? Send it in for review! Do you love using ipmitool on your or your company's servers? Pull down the cvs tree and test all your favorite commands using the latest code! ;-D
As you've probably noticed, I've been working this month on getting some of the more straightforward and previously uncommitted ipmitool patches into the cvs tree for testing. There are still several outstanding patches that have been sent to the mailing list recently that haven't yet received review comments from ipmitool-devel. I'll be happy to share my review comments on them (my $.02 adjusted for deflation :-}, but hope others will post their comments and recommendations on these as well to make sure nothing gets broken: 1) Bernard Manjou patch on 6/10/08 to include sensor i2c addr and lun to sdr/sel processing routines. (Also, see his emails on 6/17/08 and 6/18/08.) http://sourceforge.net/mailarchive/forum.php?thread_name=%21%26% 21AAAAAAAAAAAYAAAAAAAAAPEZLKEHAu5BjaF%2FT5KKLfzCgAAAEAAAAIFo9o% 2B3icxPup0SXDObBL8BAAAAAA%3D%3D%40bull.net&forum_name=ipmitool-devel My comments: This patch was deferred until after the 1.8.10 roll since it is fairly extensive. 'Course now it doesn't apply perfectly. I've emailed Bernard with my slight hackage to get his patch into the current code to make sure he agrees that what I've done is correct and I'm waiting to hear back from him. Here's a chance for the folks who haven't yet reviewed and blessed it to get their $.02 in. 2) Holger Liebig's non-linear analog sensor patch (tracker ID 1990560). http://sourceforge.net/tracker2/index.php?func=detail&aid=1990560&group_id=95200&atid=610552 My comments: Holger is working with Lukasz Michalski (who's helping him with test and patch support) to complete and post an updated patch soon which includes fixes for the sdr command to work with these sensors as well. 3) Olivier Fourdan's 9/1/08 (resent 9/2/08) patch to use ipmievd to warn when the SEL buffer is getting too full. <sorry -- can't get a URL pointer at the moment> My comments: This seems like a great idea and looks like a nice patch. My main concern is that I'd want to make sure there aren't too many warning messages popping out to the point where it might be considered annoying. I haven't tested it yet though so that concern may be totally unfounded (expect I'll get a chance to test it soon). Has anyone else tested this? Any more review comments/concerns? 4) Kevin Hart's 11/12/08 patch to fix some issues he found with the sdr fill command. <sorry -- can't get a URL for this one at the moment either> My comments: Nice usage update. Please add a man page update too. ;-) Since this changes the way the fill command is called/used, plus it changes the max write length, I was hoping more folks on the list would review it and comment. Anyone? Please? 5) Mohan Kumar's 12/24/08 patch to log ipmievd events to servicelog. http://sourceforge.net/mailarchive/message.php?msg_name=20081224062405.GA13666%40in.ibm.com My comments: Mohan has emailed me that he will be posting an updated patch with some fixes soon. Please, ipmitool-devel folks, when it's posted, please review it and post your comments/concerns. 6) Ajay Pandey's OEM enhancements patch; see emails on 3/12/08, 4/4/08, 5/10/08 and my original comments posted on 7/9/08 against #28 on that list (referred to twice in that email) ************* Ajay Pandey posts some ipmitool OEM enhancements for Dell on 3/12/08: http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200803&viewday=12 On 4/4/08, Brian Seklecki forwarded a post indicating that the patch is now available via ipmitool yum update: http://sourceforge.net/mailarchive/message.php?msg_name=1207526132.14963.57.camel%40new-host On 5/10/08, Subra Manuguri posted a patch that consisted of the DEL OEM command patch as well as fixes for compilation warnings. Subra's patch-delloem patch is uploaded to: http://ipmitool.wiki.sourceforge.net/space/filelist ************ My latest comments: Ajay has emailed me that he will be re-working his patch against the latest cvs tree and addressing some of the concerns from the original review. ipmitool-devel, please, please review his new patch once it's posted. Well, that's the major outstanding list for now. It would also be great if some folks could take a look at the list under "Tracker: Bugs". I took a look and scared myself. Maybe folks could each grab one and get some of those critters squashed? Let's make the world a better place by rolling to a great new ipmitool v1.8.11! :-) Thank you very much, Carol Hebert ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel