Hello all,
The current code for getting a sensor reading ignores the sensor owner
id from the SDR if the request was issued from any other channel than
IPMB. Would it be possible to remove this restriction in the next
release by applying the attached patch file?
The behaviour as it is now could be considered as a bug since getting a
sensor reading for a sensor with another owner id then the BMC address
would result in returning the wrong sensor reading (if there is a sensor
with the same id on the BMC itself).
If this interface check is removed ipmitool seems to correctly bridge
the "Get Sensor Reading" request to the IPMB slave address defined in
the owner id field of the SDR.
Is there any reason for ignoring the owner id on e.g. LAN channel requests?
Thanks a lot and best regards
Mirko
--- ipmitool-1.8.10.old/lib/ipmi_sdr.c 2008-07-09 22:17:03.000000000 +0200
+++ ipmitool-1.8.10/lib/ipmi_sdr.c 2009-01-23 18:18:34.000000000 +0100
@@ -444,9 +444,6 @@
struct ipmi_rs *rsp;
uint8_t save_addr;
- if ((strncmp(intf->name, "ipmb", 4)) != 0)
- return ipmi_sdr_get_sensor_reading(intf, sensor);
-
save_addr = intf->target_addr;
intf->target_addr = target;
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
