Hi Bernard,
Bernard Manjou wrote:
I agree with you and I included this interface check removal
in my patch proposal titled "Patch proposal for sensors
owned by satellite controllers".
thanks for your help! The patch has been included in the CVS repository
already and it works fine now for the lan channel. However there is
still a problem with the lanplus channel. Bridged raw commands are
working fine but a command like "sensor list" without the -t option
causes wrong double bridged requests if a sensor is located on another
satellite controller. Here is more detailed explanation:
If a command is sent with the -t option (bridged mode) there is an check
for an additional parameter "transit address" which is set to
intf->my_addr (0x20) if no other value is given with -T. For any
compound requests like "sensor list" (without -t) where the most IPMI
commands are sent directly to the BMC but single commands (e.g.
GetSensorReading due to SDR field "owner id") are sent in bridged mode
to a satellite controller the intf->transit_addr is not touched at all
and remains 0. On the lan channel double bridged mode is activated if
the transit address (intf->transit_addr) is not 0 and not the own
address (intf->my_addr). This first check (intf->transit_addr != 0) does
not exist in the lanplus handler which leads to double bridged requests
if the -t option is not given.
The attached patch files adds this check to fix commands like "sensor
list" for the lanplus channel. It Would be very much appreciated if this
could be included as well.
Thanks in advance and with regards
Mirko
Index: src/plugins/lanplus/lanplus.c
===================================================================
RCS file: /cvsroot/ipmitool/ipmitool/src/plugins/lanplus/lanplus.c,v
retrieving revision 1.65
diff -u -r1.65 lanplus.c
--- src/plugins/lanplus/lanplus.c 9 Jan 2009 21:55:47 -0000 1.65
+++ src/plugins/lanplus/lanplus.c 3 Feb 2009 16:28:07 -0000
@@ -1356,7 +1356,7 @@
else {
bridgedRequest = 1;
- if(intf->transit_addr != ourAddress)
+ if(intf->transit_addr != ourAddress && intf->transit_addr != 0)
{
bridgedRequest++;
}
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
