Hey Corey,

> Any opinions on this from anyone else?  IMHO, this is a poor design in 
> the spec, and it's silly for anyone to put a "1" in this share count field.

I concur that it's silly.  I have this recollection that I too
implemented "share_count != 0", then later changed it to "share_count >
1" in FreeIPMI when I saw that's how it was implemented in motherboards.

Al

On Fri, 2010-05-28 at 10:49 -0700, Corey Minyard wrote:
> Resend, I sent from the wrong account.
> 
> Well, this is certainly a gray area in the spec.  The SDR in question is:
> 
>  SDR
>    Record ID: 30
>    Type: 2
>    Version: 1.5
>    Data: 0x20 0x00 0x64 0x0a 0x00 0x67 0x40 0x25
>          0x08 0x03 0x00 0x00 0x00 0x03 0x00 0xc0
>          0x00 0x00 0x01 0x81 0x00 0x00 0x00 0x00
>          0x00 0x00 0xc9 0x50 0x53 0x30 0x2f 0x50
>          0x52 0x53 0x4e 0x54
> 
> 
> Bytes 18 and 19 are the ones in question, these correspond to byte 24 
> and 25 of the "SDR type 02h Compact Sensor Record".  Since the "share 
> count" is non-zero, OpenIPMI assumes that it is doing sensor sharing and 
> numbers them as specified in the spec and the other bits in those 
> bytes.  Thus it appends the "1".
> 
> You can "fix" this problem by changing lib/sensor.c, line 1441 from:
>    if (share_count) {
> to
>    if (share_count > 1) {
> 
> Any opinions on this from anyone else?  IMHO, this is a poor design in 
> the spec, and it's silly for anyone to put a "1" in this share count field.
> 
> -corey
> 
> >
> >
> > Alex Deiter wrote:
> >> Hi Corey,
> >>
> >> Also i uploaded output from command:
> >>
> >>  
> >>> mc sdrs test(0.20) main
> >>>     
> >>
> >> into http://*deiter.net.ru/mc_sdr.txt
> >>
> >> Thanks a lot!
> >>
> >> 2010/5/28 Corey Minyard <cminy...@mvista.com>:
> >>  
> >>> Can you do:
> >>>
> >>>  mc sdrs test(0.20) main
> >>>
> >>> and send me the output?
> >>>
> >>> -corey
> >>>
> >>> Alex Deiter wrote:
> >>>    
> >>>> Dear Corey,
> >>>>
> >>>> I found strange fact - on Sun x64 servers some sensors with discrete
> >>>> type has incorrect names (it different then output from ILOM,
> >>>> ipmitool, snmp etc).
> >>>> Name for some (not all)  *PRSNT sensors has suffix "1":
> >>>>
> >>>> $ openipmish
> >>>>
> >>>>      
> >>>>> domain open test lan -U root -P passwd -L user 10.1.1.1
> >>>>>
> >>>>>         
> >>>> ...
> >>>> Event
> >>>>  Object Type: Sensor
> >>>> ==>  Name: test(10.0).PS0/PRSNT1
> >>>>  Operation: Add
> >>>> ...
> >>>>
> >>>>      
> >>>>> sensor list
> >>>>>
> >>>>>         
> >>>> Entity
> >>>>  Name: test(10.0)
> >>>>  Sensors
> >>>>    Name: test(10.0).PS0/OUT_POWER
> >>>>    Name: test(10.0).PS0/IN_POWER
> >>>>    Name: test(10.0).PS0/I_OUT
> >>>>    Name: test(10.0).PS0/V_OUT
> >>>>    Name: test(10.0).PS0/I_IN
> >>>>    Name: test(10.0).PS0/V_IN
> >>>>    Name: test(10.0).PS0/TEMP_FAULT
> >>>>    Name: test(10.0).PS0/FAN_FAULT
> >>>>    Name: test(10.0).PS0/VOLT_FAULT
> >>>>    Name: test(10.0).PS0/CUR_FAULT
> >>>>    Name: test(10.0).PS0/PWROK
> >>>>    Name: test(10.0).PS0/VINOK
> >>>> ==>    Name: test(10.0).PS0/PRSNT1
> >>>>    Name: test(10.0).MB/V_+1V4
> >>>>    Name: test(10.0).MB/V_+3V3STBY
> >>>>    Name: test(10.0).MB/V_+5V
> >>>>    Name: test(10.0).MB/V_+3V3
> >>>>    Name: test(10.0).MB/V_+1V5
> >>>>
> >>>>
> >>>>      
> >>>>> sensor info test(10.0).PS0/PRSNT1
> >>>>>
> >>>>>         
> >>>> Sensor
> >>>>  Name: test(10.0).PS0/PRSNT1
> >>>>  LUN: 0
> >>>>  Number: 100
> >>>>  Event Reading Type: 8
> >>>>  Event Reading Type Name: discrete_device_presense
> >>>>  Type: 37
> >>>>  Type Name: entity_presense
> >>>>  Event Support: per state
> >>>>  Init Scanning: true
> >>>>  Init Events: true
> >>>>  Init Thresholds: false
> >>>>  Init Hysteresis: false
> >>>>  Init Type: true
> >>>>  Init Power Up Events: true
> >>>>  Init Power Up Scanning: true
> >>>>  Ignore If No Entity: false
> >>>>  Auto Rearm: true
> >>>>  OEM1: 0
> >>>>  Id: PS0/PRSNT1
> >>>>  Event
> >>>>    Offset: 0
> >>>>    Name: device removed/absent
> >>>>    Supports: assertion
> >>>>  Event
> >>>>    Offset: 1
> >>>>    Name: device inserted/present
> >>>>    Supports: assertion
> >>>>
> >>>> output from ipmitool sensor list:
> >>>> ...
> >>>> PS0/PRSNT        | 0x2        | discrete   | 0x0200| na        | na
> >>>>    | na        | na        | na        | na
> >>>> ...
> >>>> output from ipmitool sensor get PS0/PRSNT:
> >>>> Locating sensor record...
> >>>> Sensor ID              : PS0/PRSNT (0x64)
> >>>>  Entity ID             : 10.0
> >>>>  Sensor Type (Discrete): Entity Presence
> >>>>  States Asserted       : Availability State
> >>>>                         [Device Present]
> >>>>
> >>>> output from ILOM:
> >>>>
> >>>> $ ssh r...@10.1.1.1
> >>>> Password:
> >>>>
> >>>> Sun(TM) Integrated Lights Out Manager
> >>>>
> >>>> Version 3.0.6.16 r50656
> >>>>
> >>>> Copyright 2009 Sun Microsystems, Inc. All rights reserved.
> >>>> Use is subject to license terms.
> >>>>
> >>>> -> show /SYS/PS0/PRSNT
> >>>>
> >>>>  /SYS/PS0/PRSNT
> >>>>    Targets:
> >>>>
> >>>>    Properties:
> >>>>        type = Entity Presence
> >>>>        ipmi_name = PS0/PRSNT
> >>>>        class = Discrete Sensor
> >>>>        value = Present
> >>>>        alarm_status = cleared
> >>>>
> >>>> snmp also show sensor names without suffix "1".
> >>>>
> >>>> Could you please explain this behavior for OpenIPMI ?
> >>>>
> >>>> Thanks a lot!
> >>>>
> >>>> -- 
> >>>> Alex Deiter
> >>>>
> >>>>       
> >>>     
> >>
> >>
> >>
> >>   
> >
> 
> 
> ------------------------------------------------------------------------------
> 
> _______________________________________________
> Openipmi-developer mailing list
> openipmi-develo...@lists.sourceforge.net
> https://*lists.sourceforge.net/lists/listinfo/openipmi-developer
> 
-- 
Albert Chu
ch...@llnl.gov
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory


------------------------------------------------------------------------------

_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to