Hey, On Thu, Oct 20, 2011 at 5:19 AM, Harshad Prabhu (hprabhu) <hpra...@cisco.com> wrote: > Hi All > > There are lot of changes from 1.8.11 release (which was released in > 02/2009) to what is available in CVS currently. >
indeed. And check bugs and feature requests at SF.net. > When is the plan for ipmitool 1.8.12 release ?? > I would say there is not one. I kind of don't believe these guys are sticking around anymore. Or have more important projects to do, so this is like: check only once per year thing. I would be quite interested to hear the history of ipmitool, because I really don't know where SF.net fits in the puzzle I have already. Anyway, you can take 1.8.11, patch it, and then release it as 1.8.11.1. That's what Sun/Oracle obviously do. It is not the best way. No, it is actually quite stupid way, in my opinion. But it is a way. You can fork it as well, but it is not much different from previous option. Both are quite terrible in my opinion, because imagine end user having multiple ipmitools - one for A, second for B, ..., another for X. It doesn't make sense. I'm for 1.8.12 in (very) near future too. > We would like to have the lan.patch (which was sent earlier, as there is > a bug with sequence/retries in the existing code of CVS) and > ipmi_main.diff in the new release. > To add my bit. I would like these possible buffer overflows fixed. :) Best regards, Z. > Please let me know if you need any help in testing of the latest > ipmitool from our side. > > Best Regards > Harshad > > > > > --- Attached is the below mail for easy reference on lan plugin patch > sent earlier ----- > > Hi, > > This is related to sequence number/retries of ipmitool over LAN. > > In latest plugins/lan/lan.c from CVS rev 1.66 (by audetjm) we are > eliminating the sequence number to be increased when we do retry of the > same command which is really helpful. But we are still adding it in the > list "ipmi_req_add_entry" with the same command/sequence number so if we > do retry there will be two elements in the list with the same sequence > number and command number. > > Ideally we don't need to add if it's already added in the list. Attach > is the patch for reference. > > > Also there is one more corner case where Remote controller responds very > slowly where this sequence/command check fails. The scenario is that > after all the retries done it will print " Remote controller not > responding" and then carry forward with the new command [the entry list > will still have the command added in it]. And after that if the remote > controller responds with the old command response, it will try to match > from the list and will find it and match the old command response with > the latest command sent. So basically we need to clean all the entries > once we complete all the retries as we do not expect any response from > the BMC. If there is any response from BMC then it has to be rejected. > > For the above corner case, consider the example where the tool sends > "Get SDR" (0x23) and "Get Sensor Reading" (0x2D) . Considering that > sequence number is 0x10. So it will send Get SDR and store (0x23,0x10) > in the list. If it does not get response in 2 seconds it will retry and > send once more the same command (with the same sequence number). And > like this it will do for 4 times and then bail out. And try to send the > next command (0x2D) with sequence number 0x11. Now it will add > (0x2D,0x11) in the list. Now if the BMC sends response for 0x23,0x10 it > will match with the list and consider its response as the response for > 0x2D. We need to discard this response as its response for 0x23 and not > for the latest command send ie 0x2D. To handle this case we need to > clear of the list once all retries are done. > > I have created the patch with these modification. Let me know your > feedback. > > Rgds > Harshad > > ------------------------------------------------------------------------------ > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Ciosco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
