On Mon, Oct 17, 2011 at 5:43 PM, Harshad Prabhu (hprabhu) <hpra...@cisco.com> wrote: [...] > > Hi Zdenek, > > Sorry could not reply to your previous mail. > Yes when I added the patch, had used the same way as it was already there in > the file. > Please add the patch contents and make the changes for complete file. > > Thanks once again. > > Best Regards, > Harshad >
Hello Harshad,
please add attached patch to ... well, I don't know. I didn't want to
re-do your patch,
because I don't know if you have your own repository etc.
Indentations in your patch are wrong. Be careful about code formatting
and try to keep it.
Attached patch "fixes" indentations resp. replaces \s -> \t in your
previous patch. It is just
indentation fix. I didn't re-do original patch.
Speaking of code formatting, 'lib/ipmi_main.c' would use some clean
up, because it is mix
up of \t and \s indentations as well as:
~~~ SNIP ~~~
if {
}
if
{
}
~~~ SNIP ~~~
which makes code hard to read sometimes.
Have an easy Monday,
Z.
fix-indentations-lan-retries-timeout-harshad.diff
Description: Binary data
------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
