Harshad, Zdenek,

Here are the sourceforge usernames of those who have authority to commit and 
release ipmitool:
    audetjm, carolh, iceblink, pere

Historically, it was created on 06 Nov 2003 by Duncan Laurie (then at Sun), who 
has moved on now to other things.  More info available at 
http://ipmiutil.sourceforge.net/docs/ipmisw-compare.htm 

Andy

-----Original Message-----
From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com] 
Sent: Monday, October 24, 2011 12:20 AM
To: Harshad Prabhu (hprabhu)
Cc: ipmitool-devel@lists.sourceforge.net
Subject: Re: [Ipmitool-devel] Regarding Retries/Timeout for LAN/LANPLUSinterface

On Mon, Oct 17, 2011 at 5:43 PM, Harshad Prabhu (hprabhu) <hpra...@cisco.com> 
wrote:
[...]
>
> Hi Zdenek,
>
> Sorry could not reply to your previous mail.
> Yes when I added the patch, had used the same way as it was already there in 
> the file.
> Please add the patch contents and make the changes for complete file.
>
> Thanks once again.
>
> Best Regards,
> Harshad
>

Hello Harshad,

please add attached patch to ... well, I don't know. I didn't want to re-do 
your patch, because I don't know if you have your own repository etc.
Indentations in your patch are wrong. Be careful about code formatting and try 
to keep it.

Attached patch "fixes" indentations resp. replaces \s -> \t in your previous 
patch. It is just indentation fix. I didn't re-do original patch.

Speaking of code formatting, 'lib/ipmi_main.c' would use some clean up, because 
it is mix up of \t and \s indentations as well as:
~~~ SNIP ~~~
if {
}
if
{
}
~~~ SNIP ~~~

which makes code hard to read sometimes.

Have an easy Monday,
Z.
------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to