On Fri, Jan 11, 2013 at 5:02 PM, Ales Ledvinka <aledv...@redhat.com> wrote: [...] > I vote NACK since it's inconsistent. > > current: -U user1 *-U user2* > except.: -E *-a* > current: *-a* -P pass > > Option groups setting same value: > <key-option> := [ -k <key> | -K | -y <hex_key> | -Y ] > <password-option> := [ -f <password_file> | -a | -P <password> | -E ] > <oem-option> := [ -o <oemtype> | -g | -s ] > >
Errr ... what? I really don't follow. But yeah, once password is set, be it one way or another, user won't be queried about it. Anyway, I'll try to think of some elegant solution over the weekend. Z. > ----- Original Message ----- > From: "Zdenek Styblik" <zdenek.styb...@gmail.com> > To: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net> > Cc: "Ales Ledvinka" <aledv...@redhat.com> > Sent: Friday, January 11, 2013 1:32:37 PM > Subject: Code Review - ID: 3595612 - ask for password once only if used > > Hello, > > attached is a patch to prompt for password only once. As for now, > ipmitool prompts for password as many times as, eg. '-a', option has > been passed. > > Ales, please note, attached patch is different from the one you've > proposed. Is this workable? Another option would be to put the whole > getpass()-thing into if() statement. I gave it a bit of thought and > I'm not fond of proposed(original) patch. I don't mean it's bad. But > these two variants seem much simpler and cleaner(?). > > Z. ------------------------------------------------------------------------------ Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812 _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
