Hello,
Skip the Friday replies. Too hastily to be correct.
Now about the option handling inconsistency.
The -Y and -a with your last 2nd skip now:
1) -E -P -a result from last (-a)
2) -a -E -P -a result from last-1 (-P)
3) -E -a -P result from last (-P)
1st asks that's ok.
2nd asks, does not use input value and does
not use the last occurring option
3rd asks, does not use the input value and
uses last options.
BTW: What is it that you do not like on the first patch missing key
----- Original Message -----
From: "Zdenek Styblik" <zdenek.styb...@gmail.com>
To: "Ales Ledvinka" <aledv...@redhat.com>
Cc: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net>
Sent: Saturday, January 12, 2013 6:31:43 AM
Subject: Re: Code Review - ID: 3595612 - ask for password once only if used
On Fri, Jan 11, 2013 at 5:32 PM, Zdenek Styblik
<zdenek.styb...@gmail.com> wrote:
[...]
> Anyway, I'll try to think of some elegant solution over the weekend.
>
Another solution is attached.
> Z.
>
>> ----- Original Message -----
>> From: "Zdenek Styblik" <zdenek.styb...@gmail.com>
>> To: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net>
>> Cc: "Ales Ledvinka" <aledv...@redhat.com>
>> Sent: Friday, January 11, 2013 1:32:37 PM
>> Subject: Code Review - ID: 3595612 - ask for password once only if used
>>
>> Hello,
>>
>> attached is a patch to prompt for password only once. As for now,
>> ipmitool prompts for password as many times as, eg. '-a', option has
>> been passed.
>>
>> Ales, please note, attached patch is different from the one you've
>> proposed. Is this workable? Another option would be to put the whole
>> getpass()-thing into if() statement. I gave it a bit of thought and
>> I'm not fond of proposed(original) patch. I don't mean it's bad. But
>> these two variants seem much simpler and cleaner(?).
>>
>> Z.
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
