Z,
You don't need to make sure pFile is not NULL prior to the fclose() in the if
(fseek(pFile,offset...) block
since you already checked this above. This is on line 44 in your patch file.
-- Jim Mankovich | jm...@hp.com --
On 3/8/2013 12:08 AM, Zdenek Styblik wrote:
Hi all,
attached is a patch which is, in a fact, a re-work of
ipmi_fru_get_multirec_from_file() in 'lib/ipmi_fru.c'. It began as a
check for return value of a seek(), but more than just thing seemed
wrong with this function. So I took the liberty and modified couple
things, as you can see in attached diff.
Comments?
If no objections are raised, I'll commit it "soon".
Thanks,
Z.
------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
endpoint security space. For insight on selecting the right partner to
tackle endpoint security challenges, access the full report.
http://p.sf.net/sfu/symantec-dev2dev
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
endpoint security space. For insight on selecting the right partner to
tackle endpoint security challenges, access the full report.
http://p.sf.net/sfu/symantec-dev2dev
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
