Hi,

Question about having tracker for "everything". Not sure whether that's review 
policy or part of someone's workflow. Should we have a tracker for everything 
or apply common sense filtering?
I am thinking of skipping creating tracker for trivial changes like the one 
below fixing double free bug. What is your opinion on: Do we need trackers for 
changes like that? Zdenek, or anyone else?
Given the fact it's there just to cleanup the issue report since it's just few 
steps before error exit...

diff --git a/lib/ipmi_main.c b/lib/ipmi_main.c
index ce98ef4..f496933 100644
--- a/lib/ipmi_main.c
+++ b/lib/ipmi_main.c
@@ -559,6 +559,7 @@ ipmi_main(int argc, char ** argv,
                case 'U':
                        if (username)
                                free(username);
+                               username = NULL;
                        if (strlen(optarg) > 16) {
                                lprintf(LOG_ERR, "Username is too long (> 16 
bytes)");
                                goto out_free;

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to