Fom my perspective, cleaning up the errors to remove the need for -Wno-unused-return would be best. But, I wouldn't spend a lot of time writing code and tests to deal with handling all possible errors from the system calls.
-- Jim Mankovich | jm...@hp.com (MST) -- On 4/1/2013 1:20 PM, Dan Gora wrote: > On Mon, Apr 1, 2013 at 3:53 PM, Jim Mankovich <jm...@hp.com> wrote: >> Dan, Z, >> >> I use gcc 4.6.3 with a fairly recent linux stable kernel release. >> >> Here is an example of why I would like the -Wno-unused-result flag to >> remain. Notice that if you take the >> TOB kernel and compile with a pretty recent compiler and kernel you get a >> bunch of unused result warnings >> that are not of much interest. These could be cleaned up by casting the >> returns from these system calls to >> void and these warnings would go away and then we would not need >> -Wno-unused-result at all. This would >> the best way to get rid of the -Wno-unused-result flag and maintain a clean >> compilation. > Actually we probably should check the return values for failure! I'll > try and see if I can find a system here which gives these errors and > see just how bad it is to clean this up. > > Or... would we rather just punt and put -Wno-unused-return back in? > > thanks > dan > ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
