On Thu, Apr 4, 2013 at 4:40 PM, Zdenek Styblik <zdenek.styb...@gmail.com> wrote: > On Thu, Apr 4, 2013 at 9:23 PM, Dan Gora <d...@adax.com> wrote: >> On Thu, Apr 4, 2013 at 4:13 PM, Zdenek Styblik <zdenek.styb...@gmail.com> >> wrote: >>>> So that the lines don't wrap around 80 columns... I'm trying to >>>> improve the code formatting of things a bit as it's a real hodge-podge >>>> of styles. ipmi_ekanalyzer.c is a total mess, but I can see that it >>>> was just lifted whole-hog from ipmiutils. >>>> >>> >>> Yes, I've guessed what it was about. Part/chunk 3 was alright-ish. >>> Part/chunk 4 does nothing what you say. These lines end at 61/66 thus >>> I see no reason why they should be split up. Or am I missing >>> something? >> >> You must not be using 8 space tabstops then, because with 8 space >> tabstops they did in fact wrap. With chunk 4 applied, the line: >> > > Yes, I'm using 2, and? Is there some standard for tab stop width?
yeah.. 8 spaces. It's been that forever as far as I know.. I try to follow this more or less: https://www.kernel.org/doc/Documentation/CodingStyle > For > example Python is using 4 white spaces as tabs, just saying. I don't know.. I've never used python... > And is that supposed to be an argument for doing ') {' -> '){'? If No, it's an argument for doing the opposite, to add a space after the closing parathesis and before the opening bracket so that it's easier to see. > this is supposed to be "better code" formatting, then imo it isn't. Well at least it's consistent, which the current code base is anything but. thanks dan ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
