On Thu, Apr 4, 2013 at 10:17 PM, Dan Gora <d...@adax.com> wrote:
> On Thu, Apr 4, 2013 at 5:14 PM, Zdenek Styblik <zdenek.styb...@gmail.com>
> wrote:
>> On Thu, Apr 4, 2013 at 10:07 PM, Zdenek Styblik
>> <zdenek.styb...@gmail.com> wrote:
>>> On Thu, Apr 4, 2013 at 10:00 PM, Dan Gora <d...@adax.com> wrote:
>>> [...]
>>>>> What? How's that relevant what number we use for tab stops? It's
>>>>> tabulator, not a bunch of white spaces.
>>>>
>>>> I don't understand what you are saying....
>>>>
>>>> If you write code which goes up to column 80 with tabstops set to 4,
>>>> then type ':set ts=8' in vi, you'll see that the lines will all wrap,
>>>> right? It turns it into an utter mess.
>>>>
>>>
>>> Nope, it doesn't and I have ':set tw=80' on.
>>>
>>
>> And if you meant that line just ... err ... "overflows" to the next
>> line, resp. new "virtual" line is created. Yeah, sure. So?
>
> So? It's very, very hard to read!
>
>> Perhaps it would be better to use white spaces for indentation after
>> all. At least there wouldn't be need for such discussions(1 hour gone,
>> FYI).
>
> No, it would not.. Just use 8 chars for tabstops like everyone else!
>
And why is that? Why white spaces instead tabs wouldn't fix the issue
we're having here?
> If it's no big deal then just accept the patch!
>
Do you know what the big deal is? Sacrificing readability of the code
for 80 chars width. That's kind of big deal, at least for me. I don't
consider it to be better formatting, nor better readable, and not
consistent. Because that space should be there ') {'.
I said which parts of the patch I'm going to commit. For those "code
formatting" changes, I'm afraid you'll have to get somebody else.
Sorry.
Z.
------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire
the most talented Cisco Certified professionals. Visit the
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
