Dan, My intent was to say that I did not have any problem with the change you made to re-format the code. I think following the linux kernel coding style is the right way to go.
-- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/4/2013 3:09 PM, Dan Gora wrote: > On Thu, Apr 4, 2013 at 6:03 PM, Jim Mankovich <jm...@hp.com> wrote: >> I don't have any problem with the code formatting. I personally >> leave code formatting alone in ipmitool for any code I don't explicitly >> need to make a functional change to. >> > I do too.. really... I do have better things to do with my time! > However I cannot change code that I cannot read, and I cannot read > code which wraps over 80 columns all the time. > > No, I'm not hard-core about it. Of course there are exceptions. > However if we cannot all agree on simple things like "use 8 char > tabstops" and "_try_ to limit lines to 80 chars", then there is no > hope at all. That's why I try and follow the linux kernel coding > style. > > I thought that the two screen shots showed my point pretty clearly. I > cannot for the life of me understand how someone would think that the > 'before' case is somehow easier to read. > > Really I don't think that patches should be disqualified for coding > style unless there is something really egregious, especially when > there is no documented coding style and the current code is pretty > clearly a mash of many different ones. > > thanks > dan > ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
