On Thu, Apr 18, 2013 at 7:49 AM, Dmitry Bazhenov <dim...@pigeonpoint.com> wrote: > Hello, all, >
Hi, > The attached patch fixes several compile and run-time bugs in the current > ipmitool TOB: >> o lib/ipmi_sel.c >> - zero data before making request to avoid reading of uninitialized >> data This looks ok. >> o lib/ipmi_mc.c >> - do not print AUX info, if IPMC return 12-byte Get Device ID *shrug* >> response >> o lib/ipmi_picmg.c >> - add support for hexadecimal and octal formats for the command-line NACK. Yes, you're adding support for hex and oct, but it doesn't fix possibility of over/under-flow. Please, add this to ID#3528310 and it will get fixed along. Thanks! If you're willing to take it further, please, write a generic function to validate whether FRU ID is within acceptable range and use apropriate str2* functions to convert string to integer. Such thing would be "appreciated". >> parameters >> o configure.in >> - fixed build for the newer autotool releases I guess ACK. >> - do not override OS-default values for IMB, OPEN and LIPMI >> interfaces >> if the corresponding enable/disable arguments are not provided in >> the command-line NACK. Have you actually tested results of this patch? The way I see it, fix is to create _os (defaults) variables and then: ``if test "x$xenable_intf_open" = "xyes" || test "x$xenable_intf_open_os" = "xyes"; then'' I'll do the patch, eventually, if nobody else does it sooner(faster?). Regards, Z. > > > Please, review. > > Regards, > Dmitry > > > ------------------------------------------------------------------------------ > Precog is a next-generation analytics platform capable of advanced > analytics on semi-structured data. The platform includes APIs for building > apps and a phenomenal toolset for data science. Developers can use > our toolset for easy data analysis & visualization. Get a free account! > http://www2.precog.com/precogplatform/slashdotnewsletter > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
