Hello, Zdenek, Can I treat the patches as accepted or there are going to be other comments?
Regards, Dmitry 19.04.2013 12:53, Dmitry Bazhenov пишет: > Hello, Zdenek, > > I addressed your comments. Please, review. > I put the changes into separate files this time. > > In configure.ac I made default option values for all interfaces. So, > there should be no way some of them may be uninitialized. > > Also, I re-arranged such that ipmishell is automatically disabled if > there are no its prerequisites. > > In lib_picmg.c I corrected formatting and check all string to integer > conversions for errors. > > Regards, > Dmitry > > 18.04.2013 13:42, Zdenek Styblik пишет: >> On Thu, Apr 18, 2013 at 7:49 AM, Dmitry Bazhenov >> <dim...@pigeonpoint.com> wrote: >>> Hello, all, >>> >> >> Hi, >> >>> The attached patch fixes several compile and run-time bugs in the >>> current >>> ipmitool TOB: >>>> o lib/ipmi_sel.c >>>> - zero data before making request to avoid reading of >>>> uninitialized data >> >> This looks ok. >> >>>> o lib/ipmi_mc.c >>>> - do not print AUX info, if IPMC return 12-byte Get Device ID >> >> *shrug* >> >>>> response >>>> o lib/ipmi_picmg.c >>>> - add support for hexadecimal and octal formats for the >>>> command-line >> >> NACK. Yes, you're adding support for hex and oct, but it doesn't fix >> possibility of over/under-flow. Please, add this to ID#3528310 and it >> will get fixed along. Thanks! >> If you're willing to take it further, please, write a generic function >> to validate whether FRU ID is within acceptable range and use >> apropriate str2* functions to convert string to integer. Such thing >> would be "appreciated". >> >>>> parameters >>>> o configure.in >>>> - fixed build for the newer autotool releases >> >> I guess ACK. >> >>>> - do not override OS-default values for IMB, OPEN and LIPMI >>>> interfaces >>>> if the corresponding enable/disable arguments are not >>>> provided in >>>> the command-line >> >> NACK. Have you actually tested results of this patch? The way I see >> it, fix is to create _os (defaults) variables and then: >> ``if test "x$xenable_intf_open" = "xyes" || test >> "x$xenable_intf_open_os" = "xyes"; then'' >> >> I'll do the patch, eventually, if nobody else does it sooner(faster?). >> >> Regards, >> Z. >> >>> >>> >>> Please, review. >>> >>> Regards, >>> Dmitry >>> >>> >>> ------------------------------------------------------------------------------ >>> >>> Precog is a next-generation analytics platform capable of advanced >>> analytics on semi-structured data. The platform includes APIs for >>> building >>> apps and a phenomenal toolset for data science. Developers can use >>> our toolset for easy data analysis & visualization. Get a free account! >>> http://www2.precog.com/precogplatform/slashdotnewsletter >>> _______________________________________________ >>> Ipmitool-devel mailing list >>> Ipmitool-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel >>> > > > ------------------------------------------------------------------------------ > Precog is a next-generation analytics platform capable of advanced > analytics on semi-structured data. The platform includes APIs for building > apps and a phenomenal toolset for data science. Developers can use > our toolset for easy data analysis & visualization. Get a free account! > http://www2.precog.com/precogplatform/slashdotnewsletter > > > > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
