On Fri, Jul 19, 2013 at 12:15 PM, Ales Ledvinka <aledv...@redhat.com> wrote: > I did ~1 minute reproducer which consists of copy paste ipmi_parse_hex > function and main calling it and strlen on it's result. > (gdb) s > ipmi_parse_hex (str=0x400981 "222020220022202022") at xxx.c:18 > (gdb) c > Continuing. > len: 4 >
There is a bug, indeed. But not where original author described it. And to be completely honest, I'm not the one who found where the problem is. But there is a one in ipmi_parse_hex(). I don't have a time to dig into this nor to fix it at this time. Z. > ----- Original Message ----- > From: "Zdenek Styblik" <zdenek.styb...@gmail.com> > To: "Ales Ledvinka" <aledv...@redhat.com> > Cc: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net> > Sent: Friday, July 19, 2013 11:58:51 AM > Subject: Re: [Ipmitool-devel] Closure proposal - ID: 59 - option -y and 00 in > key string bug > > On Fri, Jul 19, 2013 at 11:54 AM, Ales Ledvinka <aledv...@redhat.com> wrote: >> nack. >> >> The ipmi_parse_hex outputs head\0tail. >> The tail is excluded from the min calculation for the memcpy. >> > > Ales, > > please, can you elaborate more on this one? Ideally back it up with > how to reproduce it etc. Because I fail to follow. > > Thanks, > Z. > >> ----- Original Message ----- >> From: "Zdenek Styblik" <zdenek.styb...@gmail.com> >> To: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net> >> Sent: Thursday, July 18, 2013 6:00:39 AM >> Subject: [Ipmitool-devel] Closure proposal - ID: 59 - option -y and 00 in >> key string bug >> >> Hello, >> >> I want to close ticket ``59 - option -y and 00 in key string bug'' >> >> https://sourceforge.net/p/ipmitool/bugs/59/ <<. I really don't see any >> '00' bug in there nor it does much sense as '00' !~ '\0' and '0' !~ >> '\0'. It just doesn't make sense. >> I've tried to supply kgkey with '00' in it as suggested in ticket, but >> I couldn't find anything. I admit I don't know how ipmi_parse_hex() >> works. I also admit char -> uint8_t is a bit of worry. But, >> nonetheless, I can see no bug in there. >> >> And therefore I would like to close this ticket. The only change I >> propose is to add memset() in ipmi_parse_hex() and "erase" newly >> allocated chunk of memory(diff attached). >> >> Thoughts? Opinions? Ideas? >> >> Thanks, >> Z. >> >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> Ipmitool-devel mailing list >> Ipmitool-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel >> >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> Ipmitool-devel mailing list >> Ipmitool-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
