On Thu, Jul 25, 2013 at 1:40 AM, Zdenek Styblik <zdenek.styb...@gmail.com> wrote: > Hi, > > attached is a patch to mitigate possible int *flows via user input. > It's pretty much no brainer except those shifts. Therefore I'd > appreciate if somebody could give it a look. > Are those shifts correct? > Will they work correctly on big endian too? >
well it now packs the data into the buffer in little endian format on both little endian and big endian hosts, so at least it's now consistent. It's not clear if the data is _supposed_ to be packed in little endian format, but presumably it was.. The other thing that I would recommend is that you _not_ initialize local variables when you declare them. What this does is to preclude the compiler from finding code paths where the variable is used, but uninitialized. The compiler is much better at finding those code paths than humans are. thanks dan ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
