> > Hi, > > attached is a patch to mitigate possible int *flows via user input. > It's pretty much no brainer except those shifts. Therefore I'd appreciate > if somebody could give it a look. > Are those shifts correct? > Will they work correctly on big endian too? >
[Liebig, Holger] Just a heads up: unfortunately the change breaks 'ipmitool dcmi power set_limit action power_off' due to the test for a valid integer value at the beginning of the ipmi_dcmi_pwr_slimit() function which should be valid only for the numeric options. Also, the dcmi_pwrmgmt_action_vals array has only the long description strings and no value strings, so the above command would still fail without additional work and last but not least, 'no_action' cannot be specified. Since the window for the 1.8.13 is most likely closed, these should be documented as limitations/known bugs somewhere. I will provide a patch proposal, but would like to check the other stuff as well before sending it. Holger ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
