On Mon, Dec 9, 2013 at 10:01 AM, Zdenek Styblik
<zdenek.styb...@gmail.com> wrote:
> Hello Charles,
>
> here is my review of your patch.
>
> ~~~
> +# printf "view bmcview included %s 80\n" "${BMC_OID}"
> +# printf "com2sec -Cn bmc_ctx bmc_sec default bmc_cmty\n"
> +# printf "group bmc_grp v1 bmc_sec\n"
> +# printf "access bmc_grp bmc_ctx any noauth exact bmcview none none\n"
> +# printf "proxy -Cn bmc_ctx -v 1 %s\n" "${PROXY_TOKEN}"
> + printf "proxy -v 1 %s\n" "${PROXY_TOKEN}"
> ~~~
>
> Why are we going to keep commented stuff around?
>
> ~~~
> + mkdir ${SNMPD_BMC_CONF_DIR}
> + [ $? -ne 0 ] && RETVAL=7
> ~~~
>
> -> ``mkdir ${SNMPD_BMC_CONF_DIR} || RETVAL=7''
>
> I'd add a white space here and there.
> I haven't tested your changes and review is based on reading-through.
>
> Best regards,
> Z.
>
I forgot to add ipmitool-devel@ on CC.
Z.
> --
> Zdenek Styblik
> email: zdenek.styb...@gmail.com
> jabber: zdenek.styb...@gmail.com
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
