On 12/09/2013 04:54 AM, Zdenek Styblik wrote:
> On Mon, Dec 9, 2013 at 10:01 AM, Zdenek Styblik
> <zdenek.styb...@gmail.com> wrote:
> > Hello Charles,
> >
> > here is my review of your patch.
Thank you. I will include your comments in an updated patch to #289. Please
close this ticket.
> >
> > ~~~
> > +# printf "view bmcview included %s 80\n" "${BMC_OID}"
> > +# printf "com2sec -Cn bmc_ctx bmc_sec default bmc_cmty\n"
> > +# printf "group bmc_grp v1 bmc_sec\n"
> > +# printf "access bmc_grp bmc_ctx any noauth exact bmcview none none\n"
> > +# printf "proxy -Cn bmc_ctx -v 1 %s\n" "${PROXY_TOKEN}"
> > + printf "proxy -v 1 %s\n" "${PROXY_TOKEN}"
I will change this to this instead. So users who might want to turn on v3
security can uncomment these:
printf "#view ... "
> > ~~~
> >
> > Why are we going to keep commented stuff around?
> >
> > ~~~
> > + mkdir ${SNMPD_BMC_CONF_DIR}
> > + [ $? -ne 0 ] && RETVAL=7
> > ~~~
> >
> > -> ``mkdir ${SNMPD_BMC_CONF_DIR} || RETVAL=7''
Agree.
> >
> > I'd add a white space here and there.
Will do.
> > I haven't tested your changes and review is based on reading-through.
> >
> > Best regards,
> > Z.
> >
>
> I forgot to add ipmitool-devel@ on CC.
>
> Z.
>
> > --
> > Zdenek Styblik
> > email: zdenek.styb...@gmail.com
> > jabber: zdenek.styb...@gmail.com
>
--
Charles Rose
Linux Engineering
Dell Inc.
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
