On 12/09/2013 04:54 AM, Zdenek Styblik wrote:
> On Mon, Dec 9, 2013 at 10:08 AM, Zdenek Styblik
> <[email protected]> wrote:
> > Hello Charles,
> >
> > I'm a bit confused about this patch and patch#84 I've reviewed just a
> > minute ago. Looking at it, it seems to me like iteration of previous.
> > Therefore, why are there two tickets and two patches? Why isn't former
> > closed as obsolete, if nothing else? Or should patches be applied
> > consecutively?
Z,
Thanks for your review. And sorry for the confusion. #289 is newer to #84.
Request you to close #84
(I do not seem to have any option to close it).
> >
> > ~~~
> > + rm -f ${SNMPD_BMC_CONF}
> > [ $? -ne 0 ] && RETVAL=5
> > ~~~
> >
> > -> ``rm -f ${SNMPD_BMC_CONF} || RETVAL = 5''
Agree. Will include this.
> >
> > ~~~
> > + temp_ping=$(ping -c 1 -I ${dev} ${BMC_IPv4})
> > + [ $? -ne 0 ] && continue
> > + echo $temp_ping| awk '{print $5}' && break
> > ~~~
> >
> > What exactly is purpose of this? What is the expected output here?
We use it for TRAPD_IP=$(get_host_ip)
> >
> > ~~~
> > + echo $temp_ping| awk '{print $5}' && break
> > ~~~
> >
> > -> ``printf -- "%s\n" "${temp_ping}" | ...''
Agree. Will include this change.
> >
> > Best regards,
> > Z.
> >
>
> I forgot to add ipmitool-devel@ on CC.
>
> Z.
>
> > --
> > Zdenek Styblik
> > email: [email protected]
> > jabber: [email protected]
>
--
Charles Rose
Linux Engineering
Dell Inc.
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ipmitool-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
