On Mon, Dec 9, 2013 at 10:08 AM, Zdenek Styblik
<zdenek.styb...@gmail.com> wrote:
> Hello Charles,
>
> I'm a bit confused about this patch and patch#84 I've reviewed just a
> minute ago. Looking at it, it seems to me like iteration of previous.
> Therefore, why are there two tickets and two patches? Why isn't former
> closed as obsolete, if nothing else? Or should patches be applied
> consecutively?
>
> ~~~
> + rm -f ${SNMPD_BMC_CONF}
> [ $? -ne 0 ] && RETVAL=5
> ~~~
>
> -> ``rm -f ${SNMPD_BMC_CONF} || RETVAL = 5''
>
> ~~~
> + temp_ping=$(ping -c 1 -I ${dev} ${BMC_IPv4})
> + [ $? -ne 0 ] && continue
> + echo $temp_ping| awk '{print $5}' && break
> ~~~
>
> What exactly is purpose of this? What is the expected output here?
>
> ~~~
> + echo $temp_ping| awk '{print $5}' && break
> ~~~
>
> -> ``printf -- "%s\n" "${temp_ping}" | ...''
>
> Best regards,
> Z.
>
I forgot to add ipmitool-devel@ on CC.
Z.
> --
> Zdenek Styblik
> email: zdenek.styb...@gmail.com
> jabber: zdenek.styb...@gmail.com
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
