Jakub, Do you mind resending with a Signed-off-by tag and a proper commit message so I can just pull this in?
Thanks, Brian On 06/11/2015 09:55 AM, Jakub Cajka wrote: > Hello, > according to e-mail from this ML from 2015-06-08 it seems that iprlib.so* > shouldn't be "publicly" available, i.e. not > installed in to the libdir(and/or distributed in binary rpm with headers to > make it available for linking,... etc.). Is my statement correct? > > If is, is there any upstream fix under way? > > And one additional note and question. With new build system, iprlib(is now > build in to the standalone lib and) is linked dynamically in to the iprutils > executables, > witch is change to previous state(probable cause to the up mentioned > question/"issue"). It is not explicitly mentioned in any commit messages. Is > it(dyn. linking of iprlib) intentional? > > I'm including patch which should make Makefile build(and install) binaries > (nearly the same)"old way" using current build system(and resolves first > question), also prevents installation of iprlib.h. > > I have just run in to this during packaging for fedora/rhel and want it > clarified. > > Thanks and best regards, > > Jakub Čajka > > diff -up iprutils-2.4.7/Makefile.am.libs iprutils-2.4.7/Makefile.am > --- iprutils-2.4.7/Makefile.am.libs 2015-05-07 00:04:35.000000000 +0200 > +++ iprutils-2.4.7/Makefile.am 2015-06-11 09:27:29.860540298 +0200 > @@ -7,9 +7,8 @@ > # Common Public License v1.0 which accompanies this distribution. > # > > -lib_LTLIBRARIES = libipr.la > +noinst_LTLIBRARIES = libipr.la > libipr_la_SOURCES = iprlib.c > -include_HEADERS = iprlib.h > > sbin_PROGRAMS = iprconfig iprdump iprupdate iprinit iprdbg > dist_sbin_SCRIPTS = iprsos > > > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > Iprdd-devel mailing list > Iprdd-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/iprdd-devel > -- Brian King Power Linux I/O IBM Linux Technology Center ------------------------------------------------------------------------------ _______________________________________________ Iprdd-devel mailing list Iprdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/iprdd-devel
