----- Original Message ----- > From: "Brian King" <brk...@linux.vnet.ibm.com> > To: "Jakub Cajka" <jca...@redhat.com>, iprdd-devel@lists.sourceforge.net > Sent: Thursday, June 18, 2015 8:28:09 PM > Subject: Re: [Iprdd-devel] iprlib distribution > > Jakub, > > Do you mind resending with a Signed-off-by tag and a proper commit message > so I can just pull this in? > > Thanks, > > Brian >
Sure, patch(fixed, missed the header) follows. Would it be possible to have new release by Monday? Thanks, Jakub > > On 06/11/2015 09:55 AM, Jakub Cajka wrote: > > Hello, > > according to e-mail from this ML from 2015-06-08 it seems that iprlib.so* > > shouldn't be "publicly" available, i.e. not > > installed in to the libdir(and/or distributed in binary rpm with headers > > to make it available for linking,... etc.). Is my statement correct? > > > > If is, is there any upstream fix under way? > > > > And one additional note and question. With new build system, iprlib(is > > now build in to the standalone lib and) is linked dynamically in to the > > iprutils executables, > > witch is change to previous state(probable cause to the up mentioned > > question/"issue"). It is not explicitly mentioned in any commit > > messages. Is it(dyn. linking of iprlib) intentional? > > > > I'm including patch which should make Makefile build(and install) > > binaries (nearly the same)"old way" using current build system(and > > resolves first question), also prevents installation of iprlib.h. > > > > I have just run in to this during packaging for fedora/rhel and want it > > clarified. > > > > Thanks and best regards, > > > > Jakub Čajka > > From 8a738d2a6e02fdb97e35cdf62c694be141ce9217 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20=C4=8Cajka?= <jca...@redhat.com> Date: Fri, 19 Jun 2015 09:08:58 +0200 Subject: [PATCH] Build/link libipr statically and don't install it with headers, similarly as before build system change. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jakub Čajka <jca...@redhat.com> --- Makefile.am | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8737713..340eb7a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -7,9 +7,8 @@ # Common Public License v1.0 which accompanies this distribution. # -lib_LTLIBRARIES = libipr.la -libipr_la_SOURCES = iprlib.c -include_HEADERS = iprlib.h +noinst_LTLIBRARIES = libipr.la +libipr_la_SOURCES = iprlib.c iprlib.h sbin_PROGRAMS = iprconfig iprdump iprupdate iprinit iprdbg dist_sbin_SCRIPTS = iprsos -- 2.1.0 ------------------------------------------------------------------------------ _______________________________________________ Iprdd-devel mailing list Iprdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/iprdd-devel
