What is MRI behavior if I return a number that doesn't fit in sbyte? writer.Write((sbyte)Protocols.CastToFixnum(context, self[i + j]));
Does it silently overflow? If so, we should use unchecked() region. Other than that looks good. Tomas -----Original Message----- From: Curt Hagenlocher Sent: Wednesday, May 21, 2008 3:15 PM To: IronRuby External Code Reviewers Cc: [email protected] Subject: Code Review: RubyArrayPack tfpt review /shelveset:RubyArrayPack;REDMOND\curth Significant subset of Array.pack and String.unpack -- Curt Hagenlocher [EMAIL PROTECTED] _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
