Is the "unchecked" just a formality under C#? It's not currently throwing an
exception.
IronRuby:
>>> [1000].pack('c')
=> "\350"
Matz:
irb(main):012:0> [1000].pack('c')
=> "\350"
-----Original Message-----
From: Tomas Matousek
Sent: Wednesday, May 21, 2008 3:24 PM
To: Curt Hagenlocher; IronRuby External Code Reviewers
Cc: [email protected]
Subject: RE: Code Review: RubyArrayPack
What is MRI behavior if I return a number that doesn't fit in sbyte?
writer.Write((sbyte)Protocols.CastToFixnum(context, self[i + j]));
Does it silently overflow? If so, we should use unchecked() region.
Other than that looks good.
Tomas
-----Original Message-----
From: Curt Hagenlocher
Sent: Wednesday, May 21, 2008 3:15 PM
To: IronRuby External Code Reviewers
Cc: [email protected]
Subject: Code Review: RubyArrayPack
tfpt review /shelveset:RubyArrayPack;REDMOND\curth
Significant subset of Array.pack and String.unpack
--
Curt Hagenlocher
[EMAIL PROTECTED]
_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core
