While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit?
Thanks, JD > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:ironruby-core- > [EMAIL PROTECTED] On Behalf Of Jim Deville > Sent: Tuesday, July 15, 2008 2:31 PM > To: [email protected]; IronRuby External Code Reviewers > Subject: Re: [Ironruby-core] Code Review: unni1 > > Reviewed F2F with John > > > JD > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:ironruby-core- > > [EMAIL PROTECTED] On Behalf Of Jim Deville > > Sent: Tuesday, July 15, 2008 1:45 PM > > To: IronRuby External Code Reviewers > > Cc: [email protected] > > Subject: [Ironruby-core] Code Review: unni1 > > > > tfpt review "/shelveset:unni1;REDMOND\jdeville" > > Comment : > > Patch from Unnikrishnan Nair to properly handle File.zero? for > 'NUL' > > > > _______________________________________________ > Ironruby-core mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
