Jim,
As per your comments, I have modified the code and ran against Matz Ruby and
verified the results. Yes you are correct 'nul' is same as 'NUL' as well. I
have updated the patch as well.
Just curious, how come there is no representation of IronRuby in Lonestar Ruby
conference?
Thanks.
Unni
--- On Wed, 7/16/08, Unnikrishnan Nair <[EMAIL PROTECTED]> wrote:
From: Unnikrishnan Nair <[EMAIL PROTECTED]>
Subject: Re: [Ironruby-core] Code Review: unni1
To: [email protected]
Date: Wednesday, July 16, 2008, 10:34 AM
yes, I will do that.
Thanks.
Unni
--- On Tue, 7/15/08, Jim Deville <[EMAIL PROTECTED]> wrote:
From: Jim Deville <[EMAIL PROTECTED]>
Subject: Re: [Ironruby-core] Code Review: unni1
To: "[email protected]" <[email protected]>, "IronRuby
External Code Reviewers" <[EMAIL PROTECTED]>
Date: Tuesday, July 15, 2008, 3:51 PM
While testing this manually I discovered that CRuby treats nul and NUL as zero
length files, while this patch only works for NUL. Unni, can you fix that and
resubmit?
Thanks,
JD
> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:ironruby-core-
> [EMAIL PROTECTED] On Behalf Of Jim Deville
> Sent: Tuesday, July 15, 2008 2:31 PM
> To: [email protected]; IronRuby External Code Reviewers
> Subject: Re: [Ironruby-core] Code Review: unni1
>
> Reviewed F2F with John
>
>
> JD
>
> > -----Original Message-----
> > From: [EMAIL PROTECTED] [mailto:ironruby-core-
> > [EMAIL PROTECTED] On Behalf Of Jim Deville
> > Sent: Tuesday, July 15, 2008 1:45 PM
> > To: IronRuby External Code Reviewers
> > Cc: [email protected]
> > Subject: [Ironruby-core] Code Review: unni1
> >
> > tfpt review "/shelveset:unni1;REDMOND\jdeville"
> > Comment :
> > Patch from Unnikrishnan Nair to properly handle File.zero? for
> 'NUL'
> >
>
> _______________________________________________
> Ironruby-core mailing list
> [email protected]
> http://rubyforge.org/mailman/listinfo/ironruby-core
_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core
_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core
