Thanks! Looks good. Submit a pull request and I'll merge it in. You can submit a pull request along with sending it to the mailing list for code review; it's a good way to keep track of open reviews.
~js On Aug 1, 2011, at 9:17 AM, Enrico Sada wrote: > Hi, i fixed workitem #6244 > (https://github.com/enricosada/IronLanguages/commit/c9d8339441e21a90216b9b51cffd23f5225d0174), > i added '%N' option to time.strftime. > > I added also the test to strftime mspec. I dont think i need to change > ironruby-tags-19, because the new test should pass now. > > This is my first commit to ironruby, wiki say i need to ask to ml for code > review before pull request. There is other i need to do? > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core@rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core
_______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core