+1 Sorry for not sending it yesterday as I promised cause the full site build took a while and I had to sleep :D. Details of what I've done to verify the build:
1- Checked keys/signs and digests. 2- RAT 3- Build and site/documentation build 4- Tests/Smoke tests 5- Archetype tests and playing with the generated projects As far as I am concerned all was OK, hence my vote. On Fri, Jul 8, 2011 at 11:39 PM, Mohammad Nour El-Din <[email protected]> wrote: > No problem Mark, I am still doing mine as well, but I am about to > finish it ;). We still need more votes anyway. But we need to stick to > a date, I suggest that max. we need to finish the vote required tests > by the end if this weekend which is by tomorrow evening for me :D. Is > that OK for all of you ? > > On Fri, Jul 8, 2011 at 11:29 PM, Mark Struberg <[email protected]> wrote: >> hi! week was way to long. I'll do my review tomorrow morning, ok? >> >> LieGrue, >> strub >> >> --- On Fri, 7/8/11, Kevin Meyer - KMZ <[email protected]> wrote: >> >>> From: Kevin Meyer - KMZ <[email protected]> >>> Subject: Re: [VOTE] Apache Isis release 0.1.2-incubating (RC5) >>> To: [email protected] >>> Date: Friday, July 8, 2011, 6:47 PM >>> Hi Dan, >>> >>> > Please verify the release and cast your vote. >>> The vote will be open >>> > for at least 72 hours. >>> > >>> > [ X ] +1 >>> >>> >>> Things were a little confusing - the >>> ~/.m2/archetype-catalog.xml >>> definitely contained a definition for 0.1.2-incubating, >>> which was what >>> royally confused me that the archetype:generate command >>> kept failing >>> with a reference to 0.1.2-incubating-SNAPSHOT. >>> >>> What I did do, though, was at some point (after editting >>> the >>> src/site/resources/archetype-catalog.xml) to manually enter >>> the RC5 >>> quickstart-archetype directory and install it (mvn -o clean >>> install). >>> >>> Thereafter I could generate the archetype, which worked. >>> >>> If I assume that I temporarily had a contaminated >>> ~/.m2/archetype- >>> catalog.xml, then I am happy to accept RC5. Especially >>> seeing that the >>> quickstart-archetype module is included by default. >>> >>> So, from me, +1 >>> >>> Regards, >>> Kevin >>> >>> On 8 Jul 2011 at 17:56, Dan Haywood wrote: >>> >>> > > If I manually edit and change the version (and >>> follow up with an "mvn >>> > > archetype:crawl"), then I can create from >>> archetype and run them all >>> > > successfully - dnd, json, xhtml and html via the >>> quickrun module, >>> > > wicket and scimpi via importing the project into >>> Eclpse (Helios) with no >>> > > problems. >>> > >>> > The version of the archetype is found from the >>> > ~/.m2/archetype-catalog.xml. So when you say you >>> obliterate earlier >>> > versions of Isis, do you also remove/edit this >>> file? As you probably >>> > know, mvn archetype:crawl updates this local copy of >>> > archetype-catalog.xml, so that may be things work once >>> you've run that >>> > command? >>> > >>> > >>> > > If the above version issue is considered >>> non-blocking, let me know, so >>> > > I can reveal my vote. >>> > I'd consider it non-blocking. >>> > >>> > >>> > Cheers >>> > Dan >>> > >>> > > Regards, >>> > > Kevin >>> >>> >> > > > > -- > Thanks > - Mohammad Nour > Author of (WebSphere Application Server Community Edition 2.0 User Guide) > http://www.redbooks.ibm.com/abstracts/sg247585.html > - LinkedIn: http://www.linkedin.com/in/mnour > - Blog: http://tadabborat.blogspot.com > ---- > "Life is like riding a bicycle. To keep your balance you must keep moving" > - Albert Einstein > > "Writing clean code is what you must do in order to call yourself a > professional. There is no reasonable excuse for doing anything less > than your best." > - Clean Code: A Handbook of Agile Software Craftsmanship > > "Stay hungry, stay foolish." > - Steve Jobs > -- Thanks - Mohammad Nour Author of (WebSphere Application Server Community Edition 2.0 User Guide) http://www.redbooks.ibm.com/abstracts/sg247585.html - LinkedIn: http://www.linkedin.com/in/mnour - Blog: http://tadabborat.blogspot.com ---- "Life is like riding a bicycle. To keep your balance you must keep moving" - Albert Einstein "Writing clean code is what you must do in order to call yourself a professional. There is no reasonable excuse for doing anything less than your best." - Clean Code: A Handbook of Agile Software Craftsmanship "Stay hungry, stay foolish." - Steve Jobs
