ok, now reopened.
On 5 September 2012 20:11, Jeroen van der Wal <[email protected]> wrote: > I added a comment to the ticket but I don't have the authorisation to > reopen it. > > -Jeroen > > On Wed, Sep 5, 2012 at 8:41 PM, Dan Haywood <[email protected] > >wrote: > > > Good idea. Could you re-open the ticket and add it? > > > > > > > > On 5 September 2012 19:39, Jeroen van der Wal <[email protected]> > wrote: > > > > > Hi Dan, > > > > > > Have you also considered implementing defaults through > > > isis.properties? Something like: > > > isis.viewers.paged.standalone=30 > > > isis.viewers.paged.parented=10 > > > > > > Cheers, > > > > > > Jeroen > > > > > > > > > On Wed, Sep 5, 2012 at 7:56 PM, Dan Haywood < > > [email protected] > > > >wrote: > > > > > > > I was implementing this today; I decided to go with @Paged. > > > > > > > > One thing I discovered though is that it *isn't* actually, necessary > to > > > > have a parented vs a standalone attribute. Instead, this information > > is > > > > inferred from where the annotation is placed. > > > > > > > > 1. If placed on a collection, it relates to the parented page size: > > > > > > > > public class Order { > > > > @Paged(12) > > > > public List<LineItem> getDetails() { ... } > > > > } > > > > > > > > 2. if placed on a type, if relates to the standalone page size (as > per > > a > > > > repository query): > > > > > > > > @Paged(25) > > > > public class Order { > > > > ... > > > > } > > > > > > > > > > > > Dan > > > > > > > > > > > > On 5 September 2012 09:26, Kevin Meyer - KMZ <[email protected]> > wrote: > > > > > > > > > Hi, > > > > > > > > > > Sorry - I missed this message.. phone screen too small :) > > > > > > > > > > Just to add: Nope, *I* think your suggestions are fine. > > > > > > > > > > Regards, > > > > > Kevin > > > > > > > > > > On 3 Sep 2012 at 23:13, Dan Haywood wrote: > > > > > > > > > > > Thanks for that. > > > > > > > > > > > > In the new support I've been adding for @Hidden(where=) [1], I > > > > > distinguish > > > > > > between parented collections and standalone collections. > > > > > > > > > > > > It occurred to me that we might want to specify different > > pagination > > > > > sizes > > > > > > for these two scenarios. > > > > > > > > > > > > So, something like: > > > > > > > > > > > > @Pagination(parented=10, standalone=25) > > > > > > or > > > > > > @Paged(parented=10, standalone=25) > > > > > > > > > > > > Any further opinions from anyone? > > > > > > > > > > > > Thx > > > > > > Dan > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/ISIS-258 > > > > > > > > > > > > > > > > > > > > > > > > On 2 September 2012 20:34, Kevin Meyer - KMZ <[email protected]> > > > wrote: > > > > > > > > > > > > > Hi Dan, > > > > > > > > > > > > > > To avoid any possible ambiguity with physical page size, I > would > > go > > > > for > > > > > > > your last suggestion: > > > > > > > @Pagination(size=25) [or @Pagination(25)] > > > > > > > > > > > > > > If that is too cumbersome (or you prefer a shorter annotation), > > > then > > > > > I'd > > > > > > > also accept: > > > > > > > @Paged(size=25) (or PageWith, if you twist my arm!) > > > > > > > > > > > > > > Offhand I can't think of anything else that might be better! > > > > > > > > > > > > > > Regards, > > > > > > > Kevin > > > > > > > > > > > > > > On 2 Sep 2012 at 19:53, Dan Haywood wrote: > > > > > > > > > > > > > > > The Wicket viewer has built-in support for paging of large > > > parented > > > > > > > > (Order#items) or standalone collections > > > > > (CustomerRepo#listCustomers()). > > > > > > > I > > > > > > > > intend to add an annotation to allow the number of rows per > > page > > > to > > > > > be > > > > > > > > configured. > > > > > > > > > > > > > > > > Any votes on what we call this annotation? > > > > > > > > > > > > > > > > @Page(size=25) > > > > > > > > @Paged(size=25) > > > > > > > > @PageWith(size=25) > > > > > > > > @PageSize(25) > > > > > > > > @Pagination(size=25) > > > > > > > > > > > > > > > > ... something else? > > > > > > > > > > > > > > > > For what it's worth, Naked Objects MVC uses @PageSize(25). > > > > > > > > > > > > > > > > Opinions please! > > > > > > > > > > > > > > > > Thx > > > > > > > > Dan > > > > > > > > > > > > > > > > > > > >
