lsyldliu commented on code in PR #25904:
URL: https://github.com/apache/flink/pull/25904#discussion_r1904114213
##########
docs/content.zh/docs/dev/table/materialized-table/statements.md:
##########
@@ -233,8 +233,8 @@ CREATE MATERIALIZED TABLE my_materialized_table_full
'format' = 'json',
'partition.fields.ds.date-formatter' = 'yyyy-MM-dd'
)
- FRESHNESS = INTERVAL '10' MINUTE
- REFRESH_MODE = 'FULL'
+ FRESHNESS = INTERVAL '1' HOUR
+ REFRESH_MODE = FULL
Review Comment:
We can remove this, doesn't need to enforce the refresh mode to full
##########
docs/content.zh/docs/dev/table/materialized-table/statements.md:
##########
@@ -200,11 +200,11 @@ CREATE MATERIALIZED TABLE my_materialized_table
CREATE MATERIALIZED TABLE my_materialized_table_continuous
PARTITIONED BY (ds)
WITH (
- 'format' = 'json',
+ 'format' = 'debezium-json',
'partition.fields.ds.date-formatter' = 'yyyy-MM-dd'
)
FRESHNESS = INTERVAL '10' SECOND
- REFRESH_MODE = 'CONTINUOUS'
+ REFRESH_MODE = CONTINUOUS
Review Comment:
we can remove it, doesn't need to enforce the refresh mode to continuous
##########
docs/content.zh/docs/dev/table/materialized-table/statements.md:
##########
@@ -200,11 +200,11 @@ CREATE MATERIALIZED TABLE my_materialized_table
CREATE MATERIALIZED TABLE my_materialized_table_continuous
PARTITIONED BY (ds)
WITH (
- 'format' = 'json',
Review Comment:
Can you also help fix the line 168 & line 169, line 175 & line 176, correct
the REFRESH_MODE and FRESHNESS position, the FRESHNESS should be above the
REFRESH_MODE.
##########
docs/content/docs/dev/table/materialized-table/statements.md:
##########
@@ -204,6 +204,7 @@ CREATE MATERIALIZED TABLE my_materialized_table_continuous
'partition.fields.ds.date-formatter' = 'yyyy-MM-dd'
)
FRESHNESS = INTERVAL '10' SECOND
+ REFRESH_MODE = CONTINUOUS
Review Comment:
remove it.
##########
docs/content/docs/dev/table/materialized-table/statements.md:
##########
@@ -233,6 +234,7 @@ CREATE MATERIALIZED TABLE my_materialized_table_full
'partition.fields.ds.date-formatter' = 'yyyy-MM-dd'
)
FRESHNESS = INTERVAL '1' HOUR
+ REFRESH_MODE = FULL
Review Comment:
remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
