davidradl commented on code in PR #25904:
URL: https://github.com/apache/flink/pull/25904#discussion_r1904208987
##########
docs/content.zh/docs/dev/table/materialized-table/statements.md:
##########
@@ -200,11 +200,11 @@ CREATE MATERIALIZED TABLE my_materialized_table
CREATE MATERIALIZED TABLE my_materialized_table_continuous
PARTITIONED BY (ds)
WITH (
- 'format' = 'json',
+ 'format' = 'debezium-json',
Review Comment:
I am curious. I look in the docs and some examples are `'format' =
'debezium-json' `an some are `'format' = 'json'.`. As you have changed this,
even though this was not mentioned in the Jira, should all the formats be
'debezium-json' or are some validly `'format' = 'json'.`? It would be worth
including mentioning in the docs what the supported formats are and the
considerations around `'debezium-json'` vs `'json'` if both are supported.
all the examples in `MaterializedTableStatementITCase` are `'debezium-json'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
