davidradl commented on code in PR #26630:
URL: https://github.com/apache/flink/pull/26630#discussion_r2127009033
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -443,6 +443,36 @@ public class ExecutionConfigOptions {
"The max number of async retry attempts to make
before task "
+ "execution is failed.");
+ // ------------------------------------------------------------------------
+ // Async ML_PREDICT Options
+ // ------------------------------------------------------------------------
+
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Integer>
TABLE_EXEC_ASYNC_ML_PREDICT_BUFFER_CAPACITY =
+ key("table.exec.async-ml-predict.buffer-capacity")
+ .intType()
+ .defaultValue(100)
+ .withDescription(
+ "The max number of async i/o operation that the
async ml predict can trigger.");
Review Comment:
Can we say in the description what happens when the limit is reached? And
maybe some advice on how to set this
Also the configuration name indicates this relates to buffer capacity, but
the description is talking about the maximum number of operations.
If this is buffer capacity what is the units of the 100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
