davidradl commented on code in PR #26630:
URL: https://github.com/apache/flink/pull/26630#discussion_r2127029261
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/LookupJoinCodeGenerator.scala:
##########
@@ -172,7 +162,14 @@ object LookupJoinCodeGenerator {
createLookupTypeInference(dataTypeFactory, callContext,
lookupFunctionBase, udf, functionName)
val ctx = new CodeGeneratorContext(tableConfig, classLoader)
- val operands = prepareOperands(ctx, inputType, lookupKeys, lookupKeyOrder,
fieldCopy)
+ val operands = prepareOperands(ctx, inputType, lookupKeys, fieldCopy)
+
+ // TODO: filter all records when there is any nulls on the join key,
because
Review Comment:
nit: there is -> there are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
