pnowojski commented on code in PR #26599:
URL: https://github.com/apache/flink/pull/26599#discussion_r2190267517
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -556,12 +559,21 @@ public AdaptiveScheduler(
deploymentTimeMetrics =
new DeploymentStateTimeMetrics(jobGraph.getJobType(),
jobStatusMetricsSettings);
+ this.executionStateMetricsRegistrars = new ArrayList<>(2);
+ this.executionStateMetricsRegistrars.add(
+ new DeploymentStateTimeMetrics(jobGraph.getJobType(),
jobStatusMetricsSettings));
+ if (jobGraph.getJobType() == JobType.STREAMING) {
Review Comment:
The thinking here is that this event doesn't make sense for batch, where
it's natural that not all tasks are started/running from the beginning.
In streaming on the other hand, this tells you when the job has fully
recovered.
I will explain that in the java doc and/or in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
