pnowojski commented on code in PR #26599:
URL: https://github.com/apache/flink/pull/26599#discussion_r2190281639


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -556,12 +559,21 @@ public AdaptiveScheduler(
         deploymentTimeMetrics =
                 new DeploymentStateTimeMetrics(jobGraph.getJobType(), 
jobStatusMetricsSettings);
 
+        this.executionStateMetricsRegistrars = new ArrayList<>(2);
+        this.executionStateMetricsRegistrars.add(
+                new DeploymentStateTimeMetrics(jobGraph.getJobType(), 
jobStatusMetricsSettings));
+        if (jobGraph.getJobType() == JobType.STREAMING) {

Review Comment:
   Actually this check can be dropped, as `AdaptiveScheduler` can be only used 
for streaming jobs anyway (this is already asserted in the 
`AdaptiveScheduler#assertPreconditions`). 
   
   I've mentioned that this event is only reported for streaming jobs in the 
docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to